Skip to content

test(config): update v5 agentic onboarding expectation#9488

Closed
leoromanovsky wants to merge 1 commit into
masterfrom
agent/fix-v5-agentic-onboarding-expectation
Closed

test(config): update v5 agentic onboarding expectation#9488
leoromanovsky wants to merge 1 commit into
masterfrom
agent/fix-v5-agentic-onboarding-expectation

Conversation

@leoromanovsky

@leoromanovsky leoromanovsky commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Motivation

DD_APPSEC_AGENTIC_ONBOARDING now defaults to an empty string and is included in the AppSec config object. The v5-only exact config expectation omitted that field, causing the v5 release proposal checks in #9415 to fail.

Changes

  • Add DD_APPSEC_AGENTIC_ONBOARDING: '' to the v5 AppSec config expectation.

Decisions

  • Keep the production default and telemetry behavior unchanged.
  • Fix the expectation on master so the correction can be included in the v5 release proposal.

Validation

  • Full packages/dd-trace/test/config/index.spec.js with DD_MAJOR simulated as 5: passed.
  • npm run test:trace:core: 4,029 passed; one unrelated failure because process-tags.spec.js expects the checkout basename to be exactly dd-trace-js, while the isolated worktree uses dd-trace-js-fix-v5-agentic-onboarding-expectation.

@dd-octo-sts

dd-octo-sts Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Overall package size

Self size: 7.51 MB
Deduped: 8.17 MB
No deduping: 8.17 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.3.2 | 124.41 kB | 440.65 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | dc-polyfill | 0.1.11 | 25.74 kB | 25.74 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter

pr-commenter Bot commented Jul 22, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-07-22 15:39:05

Comparing candidate commit 2c669cc in PR branch agent/fix-v5-agentic-onboarding-expectation with baseline commit 43a409c in branch master.

📊 Benchmarking dashboard

Found 1 performance improvements and 0 performance regressions! Performance is the same for 2310 metrics, 47 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:encoders-0.4-events-native-20

  • 🟩 max_rss_usage [-11.630MB; -3.448MB] or [-8.129%; -2.410%]

Unstable benchmarks

These benchmarks have a confidence interval too wide to call a change; treat them as noise rather than signal.

scenario:appsec-appsec-enabled-24

  • unstable execution_time [-210.071ms; +206.881ms] or [-7.897%; +7.777%]

scenario:appsec-appsec-enabled-26

  • unstable execution_time [-229.182ms; +232.792ms] or [-8.961%; +9.102%]

scenario:appsec-appsec-enabled-with-attacks-24

  • unstable execution_time [-165.496ms; +155.140ms] or [-5.348%; +5.013%]

scenario:appsec-appsec-enabled-with-attacks-26

  • unstable execution_time [-188.177ms; +183.012ms] or [-6.478%; +6.300%]

scenario:appsec-control-20

  • unstable execution_time [-126303.871µs; +125603.237µs] or [-7.656%; +7.614%]

scenario:appsec-control-24

  • unstable execution_time [-107.408ms; +129.561ms] or [-8.709%; +10.505%]

scenario:appsec-control-26

  • unstable execution_time [-128.661ms; +117.601ms] or [-10.452%; +9.553%]

scenario:appsec-iast-no-vulnerability-control-20

  • unstable execution_time [-18.516ms; +11.105ms] or [-7.260%; +4.354%]

scenario:appsec-iast-no-vulnerability-iast-enabled-default-config-20

  • unstable execution_time [-9.538ms; +18.432ms] or [-3.794%; +7.332%]

scenario:appsec-iast-with-vulnerability-iast-enabled-always-active-20

  • unstable execution_time [-30.369ms; +34.241ms] or [-5.555%; +6.264%]

scenario:child_process-shell-string-24

  • unstable execution_time [-14.238ms; +23.681ms] or [-4.420%; +7.352%]

scenario:debugger-line-probe-with-snapshot-default-26

  • unstable cpu_user_time [-2262.630ms; +720.925ms] or [-23.689%; +7.548%]
  • unstable execution_time [-2273.645ms; +734.567ms] or [-22.099%; +7.140%]
  • unstable instructions [-20.3G instructions; +6.6G instructions] or [-25.479%; +8.257%]
  • unstable throughput [-146.090op/s; +449.317op/s] or [-4.539%; +13.959%]

scenario:debugger-line-probe-with-snapshot-minimal-24

  • unstable cpu_user_time [-2807.315ms; +2777.118ms] or [-31.578%; +31.239%]
  • unstable execution_time [-2805.029ms; +2793.472ms] or [-29.218%; +29.097%]
  • unstable instructions [-23812.8M instructions; +23829.5M instructions] or [-32.727%; +32.750%]
  • unstable max_rss_usage [-11440.868KB; +11579.268KB] or [-7.178%; +7.265%]
  • unstable throughput [-743.587op/s; +743.432op/s] or [-21.238%; +21.234%]

scenario:debugger-line-probe-with-snapshot-minimal-26

  • unstable cpu_user_time [-2713.726ms; +4254.594ms] or [-28.401%; +44.528%]
  • unstable execution_time [-2861.466ms; +4409.237ms] or [-27.806%; +42.847%]
  • unstable instructions [-23.4G instructions; +37.0G instructions] or [-29.385%; +46.395%]
  • unstable max_rss_usage [-8.312MB; +13.895MB] or [-5.211%; +8.711%]
  • unstable throughput [-838.769op/s; +559.024op/s] or [-25.956%; +17.299%]

scenario:debugger-line-probe-without-snapshot-24

  • unstable cpu_user_time [-2022.095ms; +3215.600ms] or [-24.451%; +38.882%]
  • unstable execution_time [-2056.842ms; +3249.480ms] or [-22.935%; +36.234%]
  • unstable instructions [-17.1G instructions; +27.3G instructions] or [-25.319%; +40.256%]
  • unstable max_rss_usage [-8.135MB; +13.154MB] or [-5.187%; +8.387%]
  • unstable throughput [-862.924op/s; +549.241op/s] or [-23.473%; +14.940%]

scenario:debugger-line-probe-without-snapshot-26

  • unstable cpu_user_time [-2595.382ms; +4123.092ms] or [-27.166%; +43.156%]
  • unstable execution_time [-2637.068ms; +4147.943ms] or [-25.648%; +40.342%]
  • unstable instructions [-23.2G instructions; +37.0G instructions] or [-29.127%; +46.351%]
  • unstable max_rss_usage [-8.542MB; +12.712MB] or [-5.367%; +7.987%]
  • unstable throughput [-811.459op/s; +520.651op/s] or [-25.179%; +16.155%]

scenario:dogstatsd-with-tags-20

  • unstable cpu_user_time [-233.911ms; +402.879ms] or [-4.745%; +8.172%]
  • unstable execution_time [-237.549ms; +403.199ms] or [-4.746%; +8.056%]
  • unstable throughput [-153475.071op/s; +74341.887op/s] or [-9.102%; +4.409%]

scenario:plugin-graphql-long-with-depth-and-collapse-off-20

  • unstable max_rss_usage [-25.882MB; +45.730MB] or [-6.310%; +11.149%]

scenario:plugin-graphql-long-with-depth-off-20

  • unstable max_rss_usage [-4.373MB; +9.541MB] or [-3.353%; +7.315%]

scenario:plugin-graphql-long-with-depth-off-26

  • unstable max_rss_usage [-22736.172KB; +21868.172KB] or [-10.431%; +10.033%]

scenario:plugin-graphql-long-with-depth-on-max-20

  • unstable cpu_user_time [-596.374ms; +605.462ms] or [-5.166%; +5.245%]
  • unstable execution_time [-598.731ms; +616.329ms] or [-5.085%; +5.234%]
  • unstable throughput [-3.597op/s; +3.498op/s] or [-5.264%; +5.118%]

scenario:plugin-pg-service-26

  • unstable execution_time [-55.222ms; +76.064ms] or [-6.183%; +8.517%]
  • unstable throughput [-459753.517op/s; +339844.668op/s] or [-6.750%; +4.989%]

scenario:test-optimization-large-suite-20

  • unstable max_rss_usage [-6091.452KB; +7441.119KB] or [-7.280%; +8.893%]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant