test(config): assert DD_APPSEC_AGENTIC_ONBOARDING in v5 appsec config by christophe-papazian · Pull Request #9489 · DataDog/dd-trace-js

christophe-papazian · 2026-07-22T15:26:47Z

APPSEC-69230

What

Adds DD_APPSEC_AGENTIC_ONBOARDING: '' to the expected config.appsec object in the v5-only should give priority to non-experimental options test.

Why

After #9486 merged, the v5 release pipeline started failing (e.g. this run):

AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
+   DD_APPSEC_AGENTIC_ONBOARDING: '',
  at packages/dd-trace/test/config/index.spec.js:2779

#9486 registered DD_APPSEC_AGENTIC_ONBOARDING as a namespace: "appsec" entry in supported-configurations.json with default: "". That mechanism populates config.appsec[NAME] for all major versions, so the key is now always present.

The PR updated the dedicated test and the two assertObjectContains (partial-match) tests, but missed this test, which does a strict assert.deepStrictEqual(config.appsec, {…}).

Why PR CI didn't catch it

The test is gated:

;(DD_MAJOR < 6 ? it : it.skip)('should give priority to non-experimental options', …)

It only runs under v5. #9486 merged on master (v6+), where the test is it.skip'd, so the assertion never ran. It only surfaces in the v5 release/backport pipeline.

Testing

Temporarily forced the gate open locally to confirm the assertion now passes; reverted the override before committing.

🤖 Generated with Claude Code

The v5-only "should give priority to non-experimental options" test does a strict deepStrictEqual on config.appsec. PR #9486 added DD_APPSEC_AGENTIC_ONBOARDING as a namespace:"appsec" entry (default ""), which populates config.appsec for all majors, but that test was gated on DD_MAJOR < 6 and therefore skipped in master (v6/v7) CI. It only runs in the v5 release pipeline, where the missing key broke the assertion. Add the always-present key to the expected object. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

dd-octo-sts · 2026-07-22T15:27:41Z

Overall package size

Self size: 7.51 MB
Deduped: 8.18 MB
No deduping: 8.18 MB

Dependency sizes

| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.3.2 | 124.41 kB | 440.65 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | dc-polyfill | 0.1.11 | 25.74 kB | 25.74 kB |

_{🤖 This report was automatically generated by heaviest-objects-in-the-universe}

leoromanovsky

My prototype (#9488) did the same implementation and pass locally on v5 major simulation.

datadog-official · 2026-07-22T15:36:16Z

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🔄 Datadog auto-retried 1 job - 1 passed on retry

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 8097519 | Docs | Datadog PR Page | Give us feedback!}

pr-commenter · 2026-07-22T15:41:38Z

Benchmarks

Benchmark execution time: 2026-07-22 15:41:33

Comparing candidate commit 8097519 in PR branch christophe-papazian/fix-PR-9486 with baseline commit 43a409c in branch master.

📊 Benchmarking dashboard

Found 0 performance improvements and 0 performance regressions! Performance is the same for 2314 metrics, 44 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

🟩 = significantly better candidate vs. baseline
🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

Unstable benchmarks

These benchmarks have a confidence interval too wide to call a change; treat them as noise rather than signal.

scenario:appsec-appsec-enabled-24

unstable execution_time [-205.715ms; +203.543ms] or [-7.739%; +7.657%]

scenario:appsec-appsec-enabled-26

unstable execution_time [-225.102ms; +235.088ms] or [-8.841%; +9.233%]

scenario:appsec-appsec-enabled-with-attacks-24

unstable execution_time [-153.116ms; +162.968ms] or [-4.964%; +5.283%]

scenario:appsec-appsec-enabled-with-attacks-26

unstable execution_time [-187.681ms; +194.254ms] or [-6.464%; +6.691%]

scenario:appsec-control-20

unstable execution_time [-123.152ms; +132.053ms] or [-7.488%; +8.030%]

scenario:appsec-control-24

unstable execution_time [-111.718ms; +108.878ms] or [-8.993%; +8.764%]

scenario:appsec-control-26

unstable execution_time [-118.234ms; +137.943ms] or [-9.577%; +11.173%]

scenario:appsec-iast-no-vulnerability-iast-enabled-always-active-20

unstable execution_time [-14.524ms; +22.229ms] or [-5.545%; +8.487%]

scenario:child_process-shell-string-24

unstable execution_time [-20.763ms; +12.268ms] or [-6.366%; +3.762%]

scenario:debugger-line-probe-with-snapshot-default-26

unstable cpu_user_time [-2311.758ms; +736.630ms] or [-24.189%; +7.708%]
unstable execution_time [-2310.086ms; +754.706ms] or [-22.492%; +7.348%]
unstable instructions [-20.4G instructions; +6.6G instructions] or [-25.597%; +8.293%]
unstable throughput [-149.748op/s; +453.282op/s] or [-4.639%; +14.043%]

scenario:debugger-line-probe-with-snapshot-minimal-24

unstable cpu_user_time [-2794.568ms; +2788.277ms] or [-31.352%; +31.282%]
unstable execution_time [-2833.697ms; +2824.752ms] or [-29.427%; +29.334%]
unstable instructions [-23859.0M instructions; +23841.5M instructions] or [-32.775%; +32.750%]
unstable max_rss_usage [-11079.287KB; +11221.687KB] or [-6.933%; +7.023%]
unstable throughput [-741.502op/s; +752.055op/s] or [-21.253%; +21.555%]

scenario:debugger-line-probe-without-snapshot-24

unstable cpu_user_time [-2047.247ms; +3212.727ms] or [-24.760%; +38.856%]
unstable execution_time [-2140.399ms; +3352.844ms] or [-23.818%; +37.310%]
unstable instructions [-17.1G instructions; +27.2G instructions] or [-25.245%; +40.199%]
unstable max_rss_usage [-8.428MB; +13.074MB] or [-5.366%; +8.324%]
unstable throughput [-876.597op/s; +566.415op/s] or [-23.861%; +15.418%]

scenario:debugger-line-probe-without-snapshot-26

unstable cpu_user_time [-2286.675ms; +744.174ms] or [-23.965%; +7.799%]
unstable execution_time [-2295.535ms; +779.305ms] or [-22.307%; +7.573%]
unstable instructions [-20.4G instructions; +6.6G instructions] or [-25.605%; +8.219%]
unstable throughput [-161.051op/s; +451.184op/s] or [-5.000%; +14.007%]

scenario:dogstatsd-with-tags-20

unstable cpu_user_time [-275.795ms; +423.220ms] or [-5.743%; +8.813%]
unstable execution_time [-276.701ms; +422.419ms] or [-5.675%; +8.663%]
unstable throughput [-150615.313op/s; +99005.463op/s] or [-8.742%; +5.746%]

scenario:fs-subscribed-24

unstable cpu_usage_percentage [-6.520%; +4.269%]
unstable execution_time [-21.072ms; +33.515ms] or [-5.159%; +8.206%]
unstable throughput [-136333.532op/s; +86555.290op/s] or [-6.167%; +3.915%]

scenario:plugin-claude-agent-sdk-compact-stream-scan-26

unstable cpu_usage_percentage [-6.060%; +4.650%]

scenario:plugin-graphql-long-with-depth-off-26

unstable max_rss_usage [-23683.356KB; +22133.642KB] or [-10.858%; +10.148%]

scenario:plugin-graphql-long-with-depth-on-max-20

unstable cpu_user_time [-593.147ms; +605.276ms] or [-5.132%; +5.237%]
unstable execution_time [-601.312ms; +625.372ms] or [-5.098%; +5.301%]
unstable throughput [-3.657op/s; +3.499op/s] or [-5.360%; +5.129%]

scenario:plugin-graphql-long-with-depth-on-max-26

unstable max_rss_usage [-13.535MB; +10.640MB] or [-5.900%; +4.638%]

scenario:plugin-pg-service-20

unstable execution_time [-68.311ms; +102.079ms] or [-4.221%; +6.308%]

scenario:plugin-pino-json-log-injection-24

unstable cpu_usage_percentage [-5.935%; +4.286%]
unstable execution_time [-149.323ms; +239.679ms] or [-5.150%; +8.266%]
unstable throughput [-113931.616op/s; +70006.938op/s] or [-6.566%; +4.034%]

scenario:test-optimization-large-suite-20

unstable max_rss_usage [-6399.372KB; +4820.039KB] or [-7.800%; +5.875%]

…#9489) The v5-only "should give priority to non-experimental options" test does a strict deepStrictEqual on config.appsec. PR #9486 added DD_APPSEC_AGENTIC_ONBOARDING as a namespace:"appsec" entry (default ""), which populates config.appsec for all majors, but that test was gated on DD_MAJOR < 6 and therefore skipped in master (v6/v7) CI. It only runs in the v5 release pipeline, where the missing key broke the assertion. Add the always-present key to the expected object. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

codecov · 2026-07-22T20:41:16Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@43a409c). Learn more about missing BASE report.
⚠️ Report is 11 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##             master    #9489   +/-   ##
=========================================
  Coverage          ?   98.44%           
=========================================
  Files             ?      943           
  Lines             ?   127280           
  Branches          ?    12389           
=========================================
  Hits              ?   125298           
  Misses            ?     1982           
  Partials          ?        0

Flag	Coverage Δ
aiguard	`57.84% <ø> (?)`
aiguard-integration	`56.21% <ø> (?)`
apm-bucket-0	`57.69% <ø> (?)`
apm-bucket-1	`64.00% <ø> (?)`
apm-bucket-2	`62.75% <ø> (?)`
apm-bucket-3	`60.12% <ø> (?)`
apm-capabilities-tracing	`64.48% <ø> (?)`
apm-integrations-aerospike	`56.70% <ø> (?)`
apm-integrations-confluentinc-kafka-javascript	`61.64% <ø> (?)`
apm-integrations-couchbase	`57.14% <ø> (?)`
apm-integrations-http	`62.78% <ø> (?)`
apm-integrations-kafkajs	`62.19% <ø> (?)`
apm-integrations-next	`59.24% <ø> (?)`
apm-integrations-prisma	`58.72% <ø> (?)`
appsec	`72.90% <ø> (?)`
appsec-express_fastify_graphql	`70.42% <ø> (?)`
appsec-integration	`51.38% <ø> (?)`
appsec-kafka_ldapjs_lodash	`63.99% <ø> (?)`
appsec-mongodb-core_mongoose_mysql	`67.72% <ø> (?)`
appsec-next	`57.55% <ø> (?)`
appsec-node-serialize_passport_postgres	`67.39% <ø> (?)`
appsec-sourcing_stripe_template	`65.73% <ø> (?)`
debugger	`64.91% <ø> (?)`
instrumentations-bucket-0	`51.67% <ø> (?)`
instrumentations-bucket-1	`60.25% <ø> (?)`
instrumentations-bucket-10	`61.82% <ø> (?)`
instrumentations-bucket-11	`56.73% <ø> (?)`
instrumentations-bucket-12	`52.03% <ø> (?)`
instrumentations-bucket-13	`52.05% <ø> (?)`
instrumentations-bucket-2	`53.36% <ø> (?)`
instrumentations-bucket-3	`53.65% <ø> (?)`
instrumentations-bucket-4	`59.24% <ø> (?)`
instrumentations-bucket-5	`50.06% <ø> (?)`
instrumentations-bucket-6	`60.96% <ø> (?)`
instrumentations-bucket-7	`58.39% <ø> (?)`
instrumentations-bucket-8	`59.48% <ø> (?)`
instrumentations-bucket-9	`52.04% <ø> (?)`
instrumentations-instrumentation-couchbase	`51.10% <ø> (?)`
instrumentations-instrumentation-zlib	`51.70% <ø> (?)`
instrumentations-integration-esbuild	`34.11% <ø> (?)`
llmobs-ai_anthropic_bedrock	`62.61% <ø> (?)`
llmobs-bucket-1	`61.56% <ø> (?)`
llmobs-openai	`62.72% <ø> (?)`
llmobs-sdk	`66.22% <ø> (?)`
llmobs-vertex-ai	`59.21% <ø> (?)`
master-coverage	`98.44% <ø> (?)`
openfeature	`56.20% <ø> (?)`
openfeature-unit	`53.47% <ø> (?)`
platform-core_esbuild_instrumentations-misc	`40.41% <ø> (?)`
platform-integration	`61.50% <ø> (?)`
platform-shimmer_unit-guardrails_webpack	`39.11% <ø> (?)`
plugins-bucket-0	`57.10% <ø> (?)`
plugins-bucket-1	`54.43% <ø> (?)`
plugins-bucket-11	`62.34% <ø> (?)`
plugins-bucket-18	`62.03% <ø> (?)`
plugins-bucket-19	`60.12% <ø> (?)`
plugins-bucket-20	`62.13% <ø> (?)`
plugins-bucket-4	`58.62% <ø> (?)`
plugins-bullmq_cassandra_cookie	`61.82% <ø> (?)`
plugins-cookie-parser_crypto_dd-trace-api	`56.80% <ø> (?)`
plugins-fetch_fs_generic-pool	`58.84% <ø> (?)`
plugins-google-cloud-pubsub_grpc_handlebars	`64.76% <ø> (?)`
plugins-hapi_hono_ioredis	`60.29% <ø> (?)`
plugins-jest_knex_langgraph	`55.67% <ø> (?)`
plugins-ldapjs_light-my-request_limitd-client	`58.57% <ø> (?)`
plugins-lodash_mariadb_memcached	`58.07% <ø> (?)`
plugins-moleculer_mongodb_mongodb-core	`61.98% <ø> (?)`
plugins-mongoose_multer_mysql	`59.08% <ø> (?)`
plugins-mysql2_nats_node-serialize	`60.78% <ø> (?)`
plugins-opensearch_passport-http_pino	`59.61% <ø> (?)`
plugins-postgres_process_pug	`58.34% <ø> (?)`
plugins-redis_router_sequelize	`62.11% <ø> (?)`
plugins-test-and-upstream-rhea_undici_url	`61.69% <ø> (?)`
plugins-valkey_vm_winston	`58.07% <ø> (?)`
plugins-ws	`59.65% <ø> (?)`
profiling	`62.22% <ø> (?)`
serverless-aws-sdk-aws-sdk	`55.13% <ø> (?)`
serverless-aws-sdk-bedrockruntime	`54.82% <ø> (?)`
serverless-aws-sdk-client	`56.49% <ø> (?)`
serverless-aws-sdk-dynamodb	`55.73% <ø> (?)`
serverless-aws-sdk-eventbridge	`49.44% <ø> (?)`
serverless-aws-sdk-kinesis	`59.41% <ø> (?)`
serverless-aws-sdk-lambda	`57.46% <ø> (?)`
serverless-aws-sdk-s3	`55.67% <ø> (?)`
serverless-aws-sdk-serverless-peer-service	`59.82% <ø> (?)`
serverless-aws-sdk-sns	`60.21% <ø> (?)`
serverless-aws-sdk-sqs	`60.63% <ø> (?)`
serverless-aws-sdk-stepfunctions	`55.65% <ø> (?)`
serverless-aws-sdk-util	`51.55% <ø> (?)`
serverless-bucket-0	`54.33% <ø> (?)`
serverless-bucket-1	`59.32% <ø> (?)`
test-optimization-cucumber	`71.83% <ø> (?)`
test-optimization-cypress	`65.81% <ø> (?)`
test-optimization-jest	`73.23% <ø> (?)`
test-optimization-mocha	`73.48% <ø> (?)`
test-optimization-playwright-playwright-atr	`60.39% <ø> (?)`
test-optimization-playwright-playwright-efd	`60.58% <ø> (?)`
test-optimization-playwright-playwright-final-status	`60.55% <ø> (?)`
test-optimization-playwright-playwright-impacted-tests	`60.28% <ø> (?)`
test-optimization-playwright-playwright-reporting	`61.56% <ø> (?)`
test-optimization-playwright-playwright-test-management	`61.16% <ø> (?)`
test-optimization-playwright-playwright-test-span	`60.49% <ø> (?)`
test-optimization-selenium	`60.03% <ø> (?)`
test-optimization-testopt	`58.47% <ø> (?)`
test-optimization-vitest	`70.28% <ø> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…#9489) The v5-only "should give priority to non-experimental options" test does a strict deepStrictEqual on config.appsec. PR #9486 added DD_APPSEC_AGENTIC_ONBOARDING as a namespace:"appsec" entry (default ""), which populates config.appsec for all majors, but that test was gated on DD_MAJOR < 6 and therefore skipped in master (v6/v7) CI. It only runs in the v5 release pipeline, where the missing key broke the assertion. Add the always-present key to the expected object. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

github-actions Bot added the semver-patch label Jul 22, 2026

leoromanovsky approved these changes Jul 22, 2026

View reviewed changes

christophe-papazian marked this pull request as ready for review July 22, 2026 15:28

christophe-papazian requested a review from a team as a code owner July 22, 2026 15:28

christophe-papazian requested review from BridgeAR and removed request for a team July 22, 2026 15:28

BridgeAR approved these changes Jul 22, 2026

View reviewed changes

BridgeAR enabled auto-merge (squash) July 22, 2026 15:32

aarsilv approved these changes Jul 22, 2026

View reviewed changes

BridgeAR merged commit c49ba66 into master Jul 22, 2026
815 of 816 checks passed

BridgeAR deleted the christophe-papazian/fix-PR-9486 branch July 22, 2026 15:43

dd-octo-sts Bot mentioned this pull request Jul 22, 2026

v6.5.0 proposal #9491

Merged

This was referenced Jul 22, 2026

v5.116.0 proposal #9415

Closed

v5.116.0 proposal #9492

Merged

Uh oh!

Conversation

christophe-papazian commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

Why

Why PR CI didn't catch it

Testing

Uh oh!

dd-octo-sts Bot commented Jul 22, 2026

Overall package size

Uh oh!

leoromanovsky left a comment

Choose a reason for hiding this comment

Uh oh!

datadog-official Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pr-commenter Bot commented Jul 22, 2026

Benchmarks

Explanation

More details about the CI and significant changes

Unstable benchmarks

scenario:appsec-appsec-enabled-24

scenario:appsec-appsec-enabled-26

scenario:appsec-appsec-enabled-with-attacks-24

scenario:appsec-appsec-enabled-with-attacks-26

scenario:appsec-control-20

scenario:appsec-control-24

scenario:appsec-control-26

scenario:appsec-iast-no-vulnerability-iast-enabled-always-active-20

scenario:child_process-shell-string-24

scenario:debugger-line-probe-with-snapshot-default-26

scenario:debugger-line-probe-with-snapshot-minimal-24

scenario:debugger-line-probe-without-snapshot-24

scenario:debugger-line-probe-without-snapshot-26

scenario:dogstatsd-with-tags-20

scenario:fs-subscribed-24

scenario:plugin-claude-agent-sdk-compact-stream-scan-26

scenario:plugin-graphql-long-with-depth-off-26

scenario:plugin-graphql-long-with-depth-on-max-20

scenario:plugin-graphql-long-with-depth-on-max-26

scenario:plugin-pg-service-20

scenario:plugin-pino-json-log-injection-24

scenario:test-optimization-large-suite-20

Uh oh!

Uh oh!

codecov Bot commented Jul 22, 2026

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

christophe-papazian commented Jul 22, 2026 •

edited

Loading

datadog-official Bot commented Jul 22, 2026 •

edited

Loading