Commit 024fe4a
authored
fix(ci): harden first telemetry retrieval predicate in InstrumentationTest (#4040)
Root cause: the CI fixture (Frameworks/Custom/Version_Autoloaded) is built
with `composer update` against `nikic/fast-route:^1.3` and no committed lock
file (Makefile removes composer.lock-php* before updating), so the resolved
version tracks whatever the latest 1.3.x release is. The test hard-coded the
exact dependency version in the `app-dependencies-loaded` assertion, so each
new fast-route release broke the assertion. The resulting failure/retry
cascade surfaced as the flaky window-1 `logs_created` telemetry failure.
Fix:
- Replace the exact-version dependency assertion with a version-agnostic
check: exactly one non-ext dependency, named `nikic/fast-route`, with some
non-empty reported version.
- Harden the window-1 telemetry wait predicate to gate on `logs_created`
(instead of `spans_created`) so the first window reliably captures the
logs_created metric it asserts on.
All other assertions (integrations list, spans_created tags, app-started
ordering) are unchanged.1 parent 992399d commit 024fe4a
1 file changed
Lines changed: 5 additions & 5 deletions
Lines changed: 5 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
57 | 57 | | |
58 | 58 | | |
59 | 59 | | |
60 | | - | |
| 60 | + | |
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
| |||
101 | 101 | | |
102 | 102 | | |
103 | 103 | | |
104 | | - | |
105 | | - | |
106 | | - | |
107 | | - | |
| 104 | + | |
108 | 105 | | |
109 | 106 | | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
110 | 110 | | |
111 | 111 | | |
112 | 112 | | |
| |||
0 commit comments