build: migrate clang 17 -> 19

This matches Rust 1.84, but libdatadog recently introduced a flag
which was introduced in this version. Although this should not cause
a hard failure and libdatadog should be patched, it's also a good
idea to upgrade.

Author: morrisonlevi

dockerfiles/ci/bookworm/.env

@@ -1,2 +1,2 @@
 BOOKWORM_CURRENT_VERSION=6
-BOOKWORM_NEXT_VERSION=6
+BOOKWORM_NEXT_VERSION=7

dockerfiles/ci/bookworm/Dockerfile

@@ -9,10 +9,10 @@ ENV ACCEPT_EULA=Y
 # with cross-language link-time optimization. Needs to match rustc -Vv's llvm
 # version.
 ENV DEVLIBS \
-    libclang-17-dev \
-    libclang-rt-17-dev \
-    llvm-17-dev \
-    lld-17 \
+    libclang-19-dev \
+    libclang-rt-19-dev \
+    llvm-19-dev \
+    lld-19 \
     libbrotli-dev \
     libcurl4-openssl-dev \
     libedit-dev \
@@ -48,8 +48,8 @@ ENV RUNTIME_DEPS \
     apache2 \
     apache2-dev \
     ca-certificates \
-    clang-format-17 \
-    clang-tidy-17 \
+    clang-format-19 \
+    clang-tidy-19 \
     curl \
     debian-goodies \
     git \
@@ -70,7 +70,7 @@ ENV RUNTIME_DEPS \
 ENV PHPIZE_DEPS \
     autoconf \
     bison \
-    clang-17 \
+    clang-19 \
     cmake \
     dpkg-dev \
     file \
@@ -97,12 +97,12 @@ RUN set -eux; \
     echo "deb http://deb.debian.org/debian-debug/ bookworm-debug main" | \
         tee -a /etc/apt/sources.list; \
     \
-# Use LLVM from orig vendor (also LLVM 17 is not shipped with bookworm)
+# Use LLVM from orig vendor (also LLVM 19 is not shipped with bookworm)
     apt-get update; \
     apt-get install -y curl gnupg software-properties-common; \
     curl https://apt.llvm.org/llvm-snapshot.gpg.key | tee /etc/apt/trusted.gpg.d/apt.llvm.org.asc; \
-    add-apt-repository "deb http://apt.llvm.org/bookworm/ llvm-toolchain-bookworm-17 main"; \
-    add-apt-repository "deb-src http://apt.llvm.org/bookworm/ llvm-toolchain-bookworm-17 main"; \
+    add-apt-repository "deb http://apt.llvm.org/bookworm/ llvm-toolchain-bookworm-19 main"; \
+    add-apt-repository "deb-src http://apt.llvm.org/bookworm/ llvm-toolchain-bookworm-19 main"; \
     \
 # prevent Debian's PHP packages from being installed
 # https://github.com/docker-library/php/pull/542
@@ -136,14 +136,14 @@ RUN set -eux; \
     chown -R circleci:circleci /var/log/nginx/ /var/lib/nginx/; \
     \
 # Make clang the default compiler
-    update-alternatives --install /usr/bin/cc cc /usr/bin/clang-17 100; \
-    update-alternatives --install /usr/bin/c++ c++ /usr/bin/clang++-17 100; \
-    update-alternatives --install /usr/bin/clang clang /usr/bin/clang-17 100; \
-    update-alternatives --install /usr/bin/clang++ clang++ /usr/bin/clang++-17 100; \
-    update-alternatives --install /usr/bin/ld ld /usr/bin/ld.lld-17 100; \
-    echo "-L /usr/lib/llvm-17/lib/clang/17/lib/linux" > /usr/lib/llvm-17/bin/clang.cfg; \
+    update-alternatives --install /usr/bin/cc cc /usr/bin/clang-19 100; \
+    update-alternatives --install /usr/bin/c++ c++ /usr/bin/clang++-19 100; \
+    update-alternatives --install /usr/bin/clang clang /usr/bin/clang-19 100; \
+    update-alternatives --install /usr/bin/clang++ clang++ /usr/bin/clang++-19 100; \
+    update-alternatives --install /usr/bin/ld ld /usr/bin/ld.lld-19 100; \
+    echo "-L /usr/lib/llvm-19/lib/clang/19/lib/linux" > /usr/lib/llvm-19/bin/clang.cfg; \
 # Include libasan library path
-    echo /usr/lib/llvm-17/lib/clang/17/lib/linux > /etc/ld.so.conf.d/libasan.conf && ldconfig
+    echo /usr/lib/llvm-19/lib/clang/19/lib/linux > /etc/ld.so.conf.d/libasan.conf && ldconfig
 
 ENV CMAKE_VERSION="3.24.4"
 

dockerfiles/ci/centos/7/base.Dockerfile

@@ -188,7 +188,7 @@ RUN source scl_source enable devtoolset-7; set -ex; \
 ENV PKG_CONFIG_PATH="${PKG_CONFIG_PATH}:/usr/local/lib/pkgconfig:/usr/local/lib64/pkgconfig:/usr/local/openssl/lib/pkgconfig:/usr/local/zlib/lib/pkgconfig:/usr/local/curl/lib/pkgconfig:/usr/local/sqlite3/lib/pkgconfig"
 
 # Caution, takes a very long time! Since we have to build one from source,
-# I picked LLVM 17, which matches Rust 1.76.
+# I picked LLVM 19, which matches Rust 1.84.
 # Ordinarily we leave sources, but LLVM is 2GiB just for the sources...
 # Minimum: libclang. Nice-to-have: full toolchain including linker to play
 # with cross-language link-time optimization. Needs to match rustc -Vv's llvm
@@ -204,7 +204,7 @@ RUN source scl_source enable devtoolset-9 \
   && cd - \
   && rm -fr "${SRC_DIR}/ninja" \
   && cd /usr/local/src \
-  && git clone --depth 1 -b release/17.x https://github.com/llvm/llvm-project.git \
+  && git clone --depth 1 -b release/19.x https://github.com/llvm/llvm-project.git \
   && mkdir -vp llvm-project/build \
   && cd llvm-project/build \
   && cmake -G Ninja -DLLVM_ENABLE_PROJECTS="clang;lld" -DLLVM_TARGETS_TO_BUILD=host -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=/usr/local ../llvm \