fix(profiling): normalize ini modified flag

Author: realFlowControl

profiling/src/config.rs

@@ -916,18 +916,18 @@ unsafe extern "C" fn parse_profiling_enabled(
 
 /// Display the profiling enabled config value
 unsafe extern "C" fn display_profiling_enabled(ini_entry: *mut zend_ini_entry, type_: c_int) {
-    let tmp_value: *mut zend_string =
-        if type_ as u32 == ZEND_INI_DISPLAY_ORIG && (*ini_entry).modified as u8 != 0 {
-            if !(*ini_entry).orig_value.is_null() {
-                (*ini_entry).orig_value
-            } else {
-                ptr::null_mut()
-            }
-        } else if !(*ini_entry).value.is_null() {
-            (*ini_entry).value
+    let modified = bindings::ddog_php_prof_ini_entry_modified(ini_entry);
+    let tmp_value: *mut zend_string = if type_ as u32 == ZEND_INI_DISPLAY_ORIG && modified {
+        if !(*ini_entry).orig_value.is_null() {
+            (*ini_entry).orig_value
         } else {
             ptr::null_mut()
-        };
+        }
+    } else if !(*ini_entry).value.is_null() {
+        (*ini_entry).value
+    } else {
+        ptr::null_mut()
+    };
 
     let mut value: bool = false;
     if !tmp_value.is_null() {

profiling/src/php_ffi.c

@@ -232,6 +232,10 @@ void ddog_php_prof_copy_long_into_zval(zval *dest, long num) {
     return;
 }
 
+bool ddog_php_prof_ini_entry_modified(zend_ini_entry *ini_entry) {
+    return ini_entry->modified;
+}
+
 void ddog_php_prof_zend_mm_set_custom_handlers(zend_mm_heap *heap,
                                                ddog_php_prof_zend_mm_malloc _malloc,
                                                ddog_php_prof_zend_mm_free _free,

profiling/src/php_ffi.h

@@ -137,6 +137,8 @@ void datadog_php_profiling_copy_string_view_into_zval(zval *dest, zai_str view,
  */
 void ddog_php_prof_copy_long_into_zval(zval *dest, long num);
 
+bool ddog_php_prof_ini_entry_modified(zend_ini_entry *ini_entry);
+
 /**
  * Wrapper to PHP's `zend_mm_set_custom_handlers()`. Starting from PHP 7.3
  * onwards the upstream `zend_mm_set_custom_handlers()` function will restore