fix(appsec): pass __VA_ARGS__ through CONFIG to SYSCFG to avoid empty variadic

clang 19 with -Werror,-Wc23-extensions rejects calling a variadic macro
with no argument for '...'. CONFIG's body called SYSCFG(type, name) with
only 2 args. Pass CONFIG's own __VA_ARGS__ through instead — CONFIG is
always called with at least a default value, so the variadic arg is never
empty. SYSCFG ignores the extra args in this context anyway.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: morrisonlevi

appsec/cmake/extension.cmake

@@ -56,7 +56,7 @@ if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU" AND CMAKE_CXX_COMPILER_VERSION VERSION_L
   target_compile_options(extension PRIVATE -Wall)
 else()
   target_compile_options(extension PRIVATE -Wall -Wextra $<$<COMPILE_LANGUAGE:C>:-pedantic>
-    -Werror -Wno-nullability-extension -Wno-gnu-zero-variadic-macro-arguments
+    -Werror -Wno-nullability-extension -Wno-gnu-zero-variadic-macro-arguments -Wno-c23-extensions
     -Wno-gnu-auto-type -Wno-language-extension-token
     $<$<COMPILE_LANGUAGE:CXX>:-Wno-missing-field-initializers>)
 endif()

appsec/src/extension/.clang-tidy

@@ -1,3 +1,3 @@
-Checks: '-fuchsia-trailing-return,-hicpp-vararg,-cppcoreguidelines-pro-type-vararg,-clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling,-cppcoreguidelines-pro-bounds-array-to-pointer-decay'
+Checks: '-fuchsia-trailing-return,-hicpp-vararg,-cppcoreguidelines-pro-type-vararg,-clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling,-cppcoreguidelines-pro-bounds-array-to-pointer-decay,-clang-diagnostic-c23-extensions'
 
 InheritParentConfig: true

appsec/src/extension/configuration.h

@@ -116,7 +116,7 @@ typedef enum { DD_CONFIGURATION } dd_config_id;
         zai_config_memoized_entries[DDAPPSEC_CONFIG_##name].decoded_value)
 #define CONFIG(type, name, ...)                                                \
     type(get_##name, *zai_config_get_value(DDAPPSEC_CONFIG_##name))            \
-        SYSCFG(type, name)
+        SYSCFG(type, name, __VA_ARGS__)
 DD_CONFIGURATION
 #undef CONFIG
 #undef SYSCFG