Skip to content

Commit 48d7190

Browse files
committed
fix(ci): use stable trampoline path in Valgrind pass to fix base_service leak
Set DD_SPAWN_WORKER_STABLE_TRAMPOLINE=1 in the test_extension_ci Valgrind pass so the sidecar spawn_worker writes the trampoline to a stable per- process path instead of a random temp file that gets self-deleted before Valgrind can read it. Updates libdatadog to DataDog/libdatadog#1844.
1 parent 45a2db0 commit 48d7190

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@ test_extension_ci: $(SO_FILE) $(TEST_FILES) $(TEST_STUB_FILES) $(BUILD_DIR)/run-
211211
\
212212
export TEST_PHP_JUNIT=$(JUNIT_RESULTS_DIR)/valgrind-extension-test.xml; \
213213
export TEST_PHP_OUTPUT=$(JUNIT_RESULTS_DIR)/valgrind-run-tests.out; \
214-
$(ALL_TEST_ENV_OVERRIDE) $(RUN_TESTS_CMD) -d extension=$(SO_FILE) -m -s $$TEST_PHP_OUTPUT $(BUILD_DIR)/$(TESTS) && ! grep -e '^LEAKED TEST SUMMARY' $$TEST_PHP_OUTPUT; \
214+
DD_SPAWN_WORKER_STABLE_TRAMPOLINE=1 $(ALL_TEST_ENV_OVERRIDE) $(RUN_TESTS_CMD) -d extension=$(SO_FILE) -m -s $$TEST_PHP_OUTPUT $(BUILD_DIR)/$(TESTS) && ! grep -e '^LEAKED TEST SUMMARY' $$TEST_PHP_OUTPUT; \
215215
)
216216

217217
build_tea: TEA_BUILD_TESTS=ON

libdatadog

Submodule libdatadog updated 183 files

0 commit comments

Comments
 (0)