moar build fixes

Author: cataphract

.gitlab/compile_extension.sh

@@ -27,3 +27,5 @@ wait
 # Link extension
 sed -i 's/-export-symbols .*\/ddtrace\.sym/-Wl,--retain-symbols-file=ddtrace.sym/g' ${EXTENSION_DIR}/ddtrace.ldflags
 cc -shared -Wl,-whole-archive ${MODULES_DIR}/ddtrace.a -Wl,-no-whole-archive $(cat ${EXTENSION_DIR}/ddtrace.ldflags) ${CARGO_TARGET_DIR}/debug/libddtrace_php.a -Wl,-soname -Wl,ddtrace.so -o ${MODULES_DIR}/ddtrace.so
+# should alredy be the case, but just in case ensure it's made executable
+chmod +x ${MODULES_DIR}/ddtrace.so

datadog-setup.php

@@ -956,6 +956,11 @@ function safe_copy_extension($source, $destination)
 
     $tmpName = $destination . '.tmp';
     copy($source, $tmpName);
+    // Preserve execute permission from source: required for ExecSolib (the kernel
+    // execve's ddtrace.so directly to spawn the sidecar).
+    if (!IS_WINDOWS && is_executable($source)) {
+        chmod($tmpName, fileperms($tmpName) | 0111);
+    }
     rename($tmpName, $destination);
     echo "Copied '$source' to '$destination'\n";
 }