Skip to content

Commit 645c602

Browse files
fix(appsec): unset proxy in test wrapper
1 parent 847cfbb commit 645c602

2 files changed

Lines changed: 3 additions & 4 deletions

File tree

.gitlab/generate-appsec.php

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -100,8 +100,6 @@
100100
-DCMAKE_CXX_FLAGS='-stdlib=libc++' -DCMAKE_CXX_LINK_FLAGS='-stdlib=libc++'
101101
-DDD_APPSEC_TESTING=ON -DBOOST_CACHE_PREFIX=$CI_PROJECT_DIR/boost-cache
102102
-DENABLE_ASAN=$ASAN_FLAG"
103-
# The Fabric proxy changes network failure semantics and leaks HTTP_PROXY into $_SERVER.
104-
- unset HTTP_PROXY HTTPS_PROXY http_proxy https_proxy ALL_PROXY all_proxy
105103
- ASAN_OPTIONS=malloc_context_size=0 make -j 4 xtest
106104

107105
.appsec_integration_tests:
@@ -359,8 +357,6 @@
359357
-DBOOST_CACHE_PREFIX="$CI_PROJECT_DIR/boost-cache"
360358
- |
361359
export PATH=$PATH:$HOME/.cargo/bin
362-
# The Fabric proxy changes network failure semantics and leaks HTTP_PROXY into $_SERVER.
363-
unset HTTP_PROXY HTTPS_PROXY http_proxy https_proxy ALL_PROXY all_proxy
364360
LLVM_PROFILE_FILE="/tmp/cov-ext/%p.profraw" \
365361
VERBOSE=1 make -j 4 xtest
366362
- VERBOSE=1 make -j 4 ddappsec_helper_test

appsec/cmake/run-tests-wrapper.sh

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,9 @@ else
6868
set -- "${@:1:$#-1}" "${EXTRA_FLAGS[@]}" "${!#}"
6969
fi
7070

71+
# The Fabric proxy leaks HTTP_PROXY into $_SERVER as a request header.
72+
unset HTTP_PROXY HTTPS_PROXY http_proxy https_proxy ALL_PROXY all_proxy
73+
7174
set -x
7275
exec "$@"
7376

0 commit comments

Comments
 (0)