Skip to content

Commit 7684608

Browse files
PROFeNoMbwoebi
authored andcommitted
style: Use hook_method
1 parent 8634d86 commit 7684608

2 files changed

Lines changed: 41 additions & 34 deletions

File tree

src/DDTrace/Integrations/CakePHP/V2/CakePHPIntegrationLoader.php

Lines changed: 21 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
use DDTrace\Type;
1111
use DDTrace\Util\Normalizer;
1212
use Router;
13+
use function DDTrace\hook_method;
1314

1415
class CakePHPIntegrationLoader
1516
{
@@ -84,23 +85,26 @@ function (SpanData $span, array $args) use ($integration) {
8485
// - Controller::appError()
8586
// - Exception.handler
8687
// - Exception.renderer
87-
\DDTrace\trace_method('ExceptionRenderer', '__construct', [
88-
'instrument_when_limited' => 1,
89-
'posthook' => function (SpanData $span, array $args) use ($integration) {
90-
$integration->setError($integration->rootSpan, $args[0]);
91-
$span->meta[Tag::COMPONENT] = CakePHPIntegration::NAME;
92-
return false;
93-
},
94-
]);
95-
96-
\DDTrace\trace_method('CakeResponse', 'statusCode', [
97-
'instrument_when_limited' => 1,
98-
'posthook' => function (SpanData $span, $args, $return) use ($integration) {
99-
$integration->rootSpan->meta[Tag::HTTP_STATUS_CODE] = $return;
100-
$span->meta[Tag::COMPONENT] = CakePHPIntegration::NAME;
101-
return false;
102-
},
103-
]);
88+
\DDTrace\hook_method(
89+
'ExceptionRenderer',
90+
'__construct',
91+
function ($This, $scope, $args) use ($integration) {
92+
if ($integration->rootSpan) {
93+
$integration->setError($integration->rootSpan, $args[0]);
94+
}
95+
}
96+
);
97+
98+
\DDTrace\hook_method(
99+
'CakeResponse',
100+
'statusCode',
101+
null,
102+
function ($This, $scope, $args, $retval) use ($integration) {
103+
if ($integration->rootSpan) {
104+
$integration->rootSpan->meta[Tag::HTTP_STATUS_CODE] = $retval;
105+
}
106+
}
107+
);
104108

105109
// Create a trace span for every template rendered
106110
\DDTrace\trace_method('View', 'render', function (SpanData $span) use ($integration) {

src/DDTrace/Integrations/CakePHP/V3/CakePHPIntegrationLoader.php

Lines changed: 20 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
use DDTrace\Tag;
1212
use DDTrace\Type;
1313
use DDTrace\Util\Normalizer;
14+
use function DDTrace\hook_method;
1415

1516
class CakePHPIntegrationLoader
1617
{
@@ -75,23 +76,25 @@ function (SpanData $span) use ($integration) {
7576
}
7677
);
7778

78-
\DDTrace\trace_method('Cake\Error\Middleware\ErrorHandlerMiddleware', 'handleException', [
79-
'instrument_when_limited' => 1,
80-
'posthook' => function (SpanData $span, array $args) use ($integration) {
81-
$integration->setError($integration->rootSpan, $args[0]);
82-
$span->meta[Tag::COMPONENT] = CakePHPIntegration::NAME;
83-
return false;
84-
},
85-
]);
86-
87-
\DDTrace\trace_method('Cake\Http\Response', 'getStatusCode', [
88-
'instrument_when_limited' => 1,
89-
'posthook' => function (SpanData $span, $args, $return) use ($integration) {
90-
$integration->rootSpan->meta[Tag::HTTP_STATUS_CODE] = $return;
91-
$span->meta[Tag::COMPONENT] = CakePHPIntegration::NAME;
92-
return false;
93-
},
94-
]);
79+
\DDTrace\hook_method(
80+
'Cake\Error\Middleware\ErrorHandlerMiddleware',
81+
'handleException',
82+
function ($This, $scope, $args) use ($integration) {
83+
if ($integration->rootSpan) {
84+
$integration->setError($integration->rootSpan, $args[0]);
85+
}
86+
});
87+
88+
\DDTrace\hook_method(
89+
'Cake\Http\Response',
90+
'getStatusCode',
91+
null,
92+
function ($This, $scope, $args, $retval) use ($integration) {
93+
if ($integration->rootSpan) {
94+
$integration->rootSpan->meta[Tag::HTTP_STATUS_CODE] = $retval;
95+
}
96+
}
97+
);
9598

9699
// Create a trace span for every template rendered
97100
\DDTrace\install_hook(

0 commit comments

Comments
 (0)