test(CI): fix test_extension_ci failures across all PHP versions (#3663)

* test(CI): fix bug in request replayer

Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>

* fix(tests): filter remote config requests from CLI trace retrieval

The sidecar now reliably connects during CLI subprocess lifetime
(after the race condition fix), causing remote config polls to
land in the request-replayer dump before the actual trace request.

getAgentRequestFromCommand() was taking the first non-telemetry
request from the dump, which could be a /v0.7/config remote config
request instead of a trace. This caused flattenTraces() to receive
the remote config payload and fail with a TypeError when iterating
over span data.

Fix: filter for the first actual trace request (uri starting with
/v0.4/traces or /v0.7/traces) instead of taking [0].

* test(CI): fix pnctl tests

Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>

* test(CI): fix crashtracking disabled test

Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>

* test(CI): use try/catch in crashtracker_disabled test to avoid STDERR dependency

Different PHP versions ship different run-tests.php implementations with
different STDERR handling. Some versions don't include STDERR in the
comparison buffer, causing the Fatal error message to be missed.

Use try/catch to explicitly echo the timeout message to STDOUT so the
EXPECT section matches reliably across all PHP versions.

Also revert request-replayer image tag back to 2.0 (not 2.0-debug).

* test(CI): use EXPECTF with %A to handle Segmentation fault output

system() outputs "Segmentation fault (core dumped)" to stdout from the
shell when the child process dies with SIGSEGV. Use EXPECTF with %A
wildcards so the pattern matches regardless of this extra output, while
still reliably matching "wait for replay timeout" from the try/catch.

* test(CI): fix EXPECTF pattern for crashtracker_segfault_disabled

The EXPECTF pattern '%Await for replay timeout\n%A' generates the regex
'^.*wait for replay timeout\n.*$'. However run-tests.php trims the test
output, so there is no trailing newline and the \n after 'timeout'
never matches.

Remove the trailing '%A' line so the regex becomes '^.*wait for
replay timeout$' which matches the trimmed output:
'Segmentation fault (core dumped)\nwait for replay timeout'

* test(CI): use previous request-replayer version

Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>

---------

Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>

Author: Leiyks

.gitlab/generate-common.php

@@ -104,7 +104,7 @@ function dockerhub_login() {
       SNAPSHOT_REGEX_PLACEHOLDERS: 'path:/\S+/dd-trace-php(?=/),httpbin:(?<=//)httpbin-integration:8080'
 
   request-replayer:
-    name: registry.ddbuild.io/images/mirror/datadog/dd-trace-ci:php-request-replayer-2.0
+    name: registry.ddbuild.io/images/mirror/datadog/dd-trace-ci:php-request-replayer-2.0@sha256:4f26c11d568d2401bdd35d592aeff003b89b289e525166ee5ad376066877e4ad
     alias: request-replayer
     command: ["php", "-S", "<?= $service_bind_address ?>:80", "index.php"]
     variables:

tests/Common/CLITestCase.php

@@ -75,7 +75,13 @@ public function getTracesFromCommand($arguments = '', $overrideEnvs = [])
     public function getAgentRequestFromCommand($arguments = '', $overrideEnvs = [])
     {
         $this->executeCommand($arguments, $overrideEnvs);
-        return $this->retrieveDumpedTraceData()[0] ?? [];
+        foreach ($this->retrieveDumpedTraceData() as $request) {
+            $uri = $request['uri'] ?? '';
+            if (strpos($uri, '/v0.4/traces') === 0 || strpos($uri, '/v0.7/traces') === 0) {
+                return $request;
+            }
+        }
+        return [];
     }
 
     /**

tests/Common/TracerTestTrait.php

@@ -535,8 +535,9 @@ public function retrieveAnyDumpedData($until, $throw, $metrics = false) {
     public function retrieveDumpedTraceData($until = null, $throw = false)
     {
         return array_values(array_filter($this->retrieveDumpedData($until, $throw), function ($request) {
-            // Filter telemetry requests
-            return strpos($request["uri"] ?? "", "/telemetry/") !== 0;
+            // Only return actual trace requests, filtering out telemetry, remote config, etc.
+            $uri = $request["uri"] ?? "";
+            return strpos($uri, "/v0.4/traces") === 0 || strpos($uri, "/v0.7/traces") === 0;
         }));
     }
 
@@ -566,7 +567,9 @@ function untilTelemetryRequest($metricName) {
 
     function untilSpan(SpanAssertion $assertion) {
         return function ($request) use ($assertion) {
-            if (strpos($request["uri"] ?? "", "/telemetry/") === 0 || !isset($request['body'])) {
+            $uri = $request["uri"] ?? "";
+            $isTrace = strpos($uri, "/v0.4/traces") === 0 || strpos($uri, "/v0.7/traces") === 0;
+            if (!$isTrace || !isset($request['body'])) {
                 return false;
             }
             $traces = $this->parseRawDumpedTraces(json_decode($request['body'], true));