Skip to content

Commit c3f44f4

Browse files
bwoebimorrisonlevi
andauthored
Incorporate the sidecar communication protocol changes from libdatadog (#3695)
* Update libdatadog Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> * build(profiling): update libdatadog to v29 * Add configurable size Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> * Update for new metrics stuff Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> * Make this Makefile more cleverer Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> * Update Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> * Fixup windows * Fix test Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> * Update libdatadog Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> * Add automake Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> * Include Pid in error log messages Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> * Fix parallel build Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> * And add libtool * Rename $NIGHTLY to $NIGHTLY_BUILD * Fix warning Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> * Update libdatadog * Fix test Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> * Fix windows tests * Reorder cleanup Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> * Update lockfile Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> * Bleh we need a newer libtool than PHPs Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> * Keep the library thread alive as long as necessary Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> * Avoid auto-retries in telemetry tests Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> * Fix loader compilation Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> * Fix crash when reconnecting in background sender thread Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> --------- Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> Co-authored-by: Levi Morrison <levi.morrison@datadoghq.com>
1 parent b5ff4d5 commit c3f44f4

File tree

129 files changed

+496
-752
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

129 files changed

+496
-752
lines changed

.gitlab/generate-package.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1433,7 +1433,7 @@
14331433
image: registry.ddbuild.io/ci/libdatadog-build/ci_docker_base:67145216
14341434
tags: [ "arch:amd64" ]
14351435
rules:
1436-
- if: $CI_PIPELINE_SOURCE == "schedule" && $NIGHTLY
1436+
- if: $CI_PIPELINE_SOURCE == "schedule" && $NIGHTLY_BUILD
14371437
when: on_success
14381438
- if: $CI_COMMIT_REF_NAME =~ /^ddtrace-/
14391439
when: on_success

.gitlab/generate-tracer.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -140,17 +140,17 @@ function before_script_steps($with_docker_auth = false) {
140140
docker exec ${CONTAINER_NAME} powershell.exe "cd app; switch-php nts; C:\php\SDK\phpize.bat; .\configure.bat --enable-debug-pack; nmake"
141141

142142
# Set test environment variables
143-
docker exec ${CONTAINER_NAME} powershell.exe "setx DD_AUTOLOAD_NO_COMPILE true; setx DATADOG_HAVE_DEV_ENV 1; setx DD_TRACE_GIT_METADATA_ENABLED 0"
143+
docker exec ${CONTAINER_NAME} powershell.exe "setx DD_AUTOLOAD_NO_COMPILE true; setx DATADOG_HAVE_DEV_ENV 1; setx DD_TRACE_GIT_METADATA_ENABLED 0; setx DD_EXPERIMENTAL_PROPAGATE_PROCESS_TAGS_ENABLED 0"
144144

145145
# Run extension tests
146146
docker exec ${CONTAINER_NAME} powershell.exe 'cd app; $env:_DD_DEBUG_SIDECAR_LOG_LEVEL=trace; $env:_DD_DEBUG_SIDECAR_LOG_METHOD="""file://${pwd}\sidecar.log"""; C:\php\php.exe -n -d memory_limit=-1 -d output_buffering=0 run-tests.php -g FAIL,XFAIL,BORK,WARN,LEAK,XLEAK,SKIP --show-diff -p C:\php\php.exe -d "extension=${pwd}\x64\Release\php_ddtrace.dll" "${pwd}\tests\ext"'
147-
148-
# Try to stop the container, don't care if we fail
149-
try { docker stop -t 5 ${CONTAINER_NAME} } catch { }
150147
after_script:
151148
- |
152149
docker exec ${CONTAINER_NAME} cmd.exe /s /c xcopy /y /c /s /e C:\ProgramData\Microsoft\Windows\WER\ReportQueue .\app\dumps\
153150
exit 0
151+
- |
152+
# Try to stop the container, don't care if we fail
153+
try { docker stop -t 5 ${CONTAINER_NAME} } catch { }
154154
- 'powershell -NoProfile -Command "try { docker logs request-replayer } catch {}"'
155155
- 'powershell -NoProfile -Command "try { docker logs httpbin-integration } catch {}"'
156156
- 'powershell -NoProfile -Command "try { docker stop -t 15 request-replayer } catch {}"'

0 commit comments

Comments
 (0)