Commit cdf7e03
committed
fix(sidecar): wrap new FFI calls in ddtrace_ffi_try, refresh after fork
Addresses review feedback on PR:
- Wrap `ddog_sidecar_session_set_default_service_name` calls in
`ddtrace_ffi_try` so transport errors surface in the trace log
instead of being silently dropped.
- Use `DDOG_CHARSLICE_C("")` instead of hand-rolled CharSlice struct
literal for the user-defined case (matches the rest of sidecar.c).
- Call `ddtrace_sidecar_update_process_tags()` at the end of
`ddtrace_sidecar_handle_fork` so the child's fresh sidecar session
re-learns the svc.* source after fork; without this, child
telemetry/RC/stats payloads would drop the svc.* tag entirely
until the next external trigger.
Submodule bump picks up the companion stats-payload fix in
DataDog/libdatadog#2053.1 parent 602e778 commit cdf7e03
1 file changed
Lines changed: 10 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
153 | 153 | | |
154 | 154 | | |
155 | 155 | | |
156 | | - | |
157 | | - | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
158 | 159 | | |
159 | 160 | | |
160 | 161 | | |
161 | 162 | | |
162 | 163 | | |
163 | 164 | | |
164 | 165 | | |
165 | | - | |
166 | | - | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
167 | 169 | | |
168 | 170 | | |
169 | 171 | | |
| |||
518 | 520 | | |
519 | 521 | | |
520 | 522 | | |
| 523 | + | |
| 524 | + | |
| 525 | + | |
| 526 | + | |
521 | 527 | | |
522 | 528 | | |
523 | 529 | | |
| |||
0 commit comments