Skip to content

Commit dcc0a9c

Browse files
committed
fix tests
1 parent 0d9d364 commit dcc0a9c

5 files changed

Lines changed: 40 additions & 5 deletions

File tree

ext/process_tags.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ zend_string *ddtrace_process_tags_get_serialized(void) {
209209
}
210210

211211
const ddog_Vec_Tag *ddtrace_process_tags_get_vec(void) {
212-
if (ddtrace_process_tags_enabled()) {
212+
if (ddtrace_process_tags_enabled() && process_tags.vec.ptr) {
213213
return &process_tags.vec;
214214
}
215215

tests/ext/crashtracker_segfault.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ $rr->waitForRequest(function ($request) {
5151
if (!isset($payload["message"]["metadata"])) {
5252
break;
5353
}
54-
if (($payload["message"]["kind"] ?? "") == "Crash ping") {
54+
if (($payload["is_crash"] ?? false) !== true) {
5555
continue;
5656
}
5757

tests/ext/includes/request_replayer.inc

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,26 @@ class RequestReplayer
7272
} while (true);
7373
}
7474

75+
public function waitForRcRequest($matcher)
76+
{
77+
$i = 0;
78+
do {
79+
if ($i++ == $this->maxIteration) {
80+
throw new Exception("wait for replay timeout");
81+
}
82+
usleep($this->flushInterval);
83+
84+
$requests = $this->replayAllRcRequests();
85+
if (is_array($requests)) {
86+
foreach ($requests as $request) {
87+
if ($matcher($request)) {
88+
return $request;
89+
}
90+
}
91+
}
92+
} while (true);
93+
}
94+
7595
public function waitForDataAndReplay($ignoreTelemetry = true)
7696
{
7797
$i = 0;
@@ -104,6 +124,15 @@ class RequestReplayer
104124
])), true);
105125
}
106126

127+
public function replayAllRcRequests()
128+
{
129+
return json_decode(file_get_contents($this->endpoint . '/replay-rc-requests', false, stream_context_create([
130+
"http" => [
131+
"header" => "X-Datadog-Test-Session-Token: " . ini_get("datadog.trace.agent_test_session_token"),
132+
],
133+
])), true);
134+
}
135+
107136
public function clearDumpedData()
108137
{
109138
file_get_contents($this->endpoint . '/clear-dumped-data', false, stream_context_create([

tests/ext/live-debugger/debugger_span_decoration_probe.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ array(2) {
9898
["_dd.di.ret.probe_id"]=>
9999
string(1) "3"
100100
}
101-
string(%d) "/debugger/v1/input?ddtags=debugger_version:1.%s,env:none,version:,runtime_id:%s-%s-%s-%s-%s,host_name:%s"
101+
string(%d) "/debugger/v1/diagnostics?ddtags=debugger_version:1.%s,env:none,version:,runtime_id:%s-%s-%s-%s-%s,host_name:%s"
102102
array(1) {
103103
[0]=>
104104
array(6) {

tests/ext/remote_config/process_tags.phpt

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,14 @@ $path = put_dynamic_config_file([
2727
]);
2828

2929
try {
30-
$request = $rr->waitForRequest(function($req) {
31-
return strpos($req["uri"], '/v0.7/config') !== false;
30+
$request = $rr->waitForRcRequest(function($req) {
31+
if (strpos($req["uri"], '/v0.7/config') === false) {
32+
return false;
33+
}
34+
35+
$body = json_decode($req["body"], true);
36+
return isset($body["client"]["client_tracer"]["process_tags"])
37+
&& !empty($body["client"]["client_tracer"]["process_tags"]);
3238
});
3339
$body = json_decode($request["body"], true);
3440
} catch (Exception $e) {

0 commit comments

Comments
 (0)