profiling: drop parallel ext in language tests instead of xfailing ZTS

The ~56 'ZTS-only' language-test failures were not an upstream PHP quirk:
they are caused by the parallel extension (loaded only on the ZTS build in
the CI image), which defers 'PHP Startup' diagnostics until after the
script's first output, so deprecation/warning notices land in the wrong
place relative to the bundled --EXPECTF--.

Remove parallel.ini in run_php_language_tests.sh (alongside rdkafka and
memcached; no-op for the tracer NTS debug job where parallel is not
loaded), which makes all those tests pass on ZTS. Delete the ZTS-only
xfail list and its conditional in generate-profiler.php, restoring full
ZTS coverage. Verified 57/57 formerly-failing tests pass on ZTS with the
profiler loaded and parallel removed.

Author: realFlowControl

.gitlab/generate-profiler.php

@@ -154,6 +154,5 @@
     - echo "extension=/tmp/cargo/profiler-release/libdatadog_php_profiling.so" > /opt/php/${FLAVOUR}/conf.d/profiling.ini
     - php -v
     - cat "${XFAIL_LIST}" profiling/tests/php-language-xfail.list > /tmp/profiler-php-language-xfail.list
-    - if [ "${FLAVOUR}" = "zts" ]; then cat profiling/tests/php-language-xfail-zts.list >> /tmp/profiler-php-language-xfail.list; fi
     - export XFAIL_LIST=/tmp/profiler-php-language-xfail.list
     - .gitlab/run_php_language_tests.sh

.gitlab/run_php_language_tests.sh

@@ -4,14 +4,18 @@ set -eo pipefail
 # Helper to parse version strings for comparison
 function version { echo "$@" | awk -F. '{ printf("%d%03d%03d%03d\n", $1,$2,$3,$4); }'; }
 
-# Remove extensions whose mere presence pollutes test output (e.g. rdkafka
-# emits CONFWARN lines, breaking Zend/tests/instantiate_all_classes.phpt).
+# Remove extensions whose mere presence pollutes test output or output
+# ordering:
+#  - rdkafka emits CONFWARN lines, breaking Zend/tests/instantiate_all_classes.phpt
+#  - parallel (ZTS-only) defers 'PHP Startup' diagnostics until after the
+#    script's first output, breaking ~56 deprecation/warning-ordering tests
 # Derive the scan dir from the active PHP so this works for every build
 # variant (debug for the tracer job, nts/zts for the profiler job) instead
 # of hardcoding the debug path.
 scan_dir="$(php -r 'echo PHP_CONFIG_FILE_SCAN_DIR;')"
 sudo rm -f "${scan_dir}/memcached.ini"
 sudo rm -f "${scan_dir}/rdkafka.ini"
+sudo rm -f "${scan_dir}/parallel.ini"
 if [[ ! "${XFAIL_LIST:-none}" == "none" ]]; then
   cp "${XFAIL_LIST}" /usr/local/src/php/xfail_tests.list
   (

profiling/tests/README.md

@@ -1,42 +1,16 @@
-# PHP language test xfail lists
+# PHP language test xfail list
 
 The profiler's "PHP language tests" CI job runs the upstream PHP test suite
 with the profiling extension loaded, for every supported PHP version and for
-both the `nts` and `zts` builds. These lists exclude tests that cannot pass in
-that environment for reasons unrelated to profiler correctness.
+both the `nts` and `zts` builds. `php-language-xfail.list` excludes tests that
+cannot pass in that environment for reasons unrelated to profiler correctness.
 
 `.gitlab/run_php_language_tests.sh` **deletes** every `.phpt` named in
 `XFAIL_LIST` before running, so listing a test means "do not run" it.
 
-| File | Applies to |
-|------|------------|
-| `php-language-xfail.list` | all profiler runs (`nts` + `zts`) |
-| `php-language-xfail-zts.list` | ZTS build only (appended by the job) |
-
-ZTS-only failures live in their own list so the NTS build keeps running them.
-
-## `php-language-xfail.list`
-
-Fail with the profiler loaded on both NTS and ZTS:
+Tests fail with the profiler loaded on both NTS and ZTS:
 
 - `ext/ffi/tests/list.phpt` — aborts (`free(): invalid size`); allocation
   profiler conflicts with the test's FFI memory management.
 - `Zend/tests/concat_003.phpt` — perf-sensitive (2 s budget); allocation
   profiling overhead can exceed it on CI runners.
-
-## `php-language-xfail-zts.list`
-
-All entries pass on NTS and fail only on ZTS, and reproduce on vanilla ZTS PHP
-with no Datadog extension loaded — so none are profiler defects.
-
-Root cause: on ZTS, PHP flushes its `PHP Startup` diagnostics *after* the SAPI
-starts emitting request output; on NTS they appear before it. The bundled
-`--EXPECTF--` was written for the NTS ordering, so the diff is purely the
-position of the startup notice. The tracer language-test job only runs NTS, so
-it never hits these.
-
-The relocated diagnostic is either a `Deprecated:` notice (`assert.*`, session
-and mbstring INI deprecations, `allow_url_include`, `filter.default`,
-`auto_detect_line_endings`, …) or a `Warning:`/`Fatal error:` (`date.timezone`,
-invalid mbstring encoding, `session.name`/`upload_progress`, session
-save-handler, `zend_test.quantity_value`).