Skip to content

Move appsec communication to sidecar#3725

Draft
cataphract wants to merge 1 commit intomasterfrom
glopes/sidecar-comm
Draft

Move appsec communication to sidecar#3725
cataphract wants to merge 1 commit intomasterfrom
glopes/sidecar-comm

Conversation

@cataphract
Copy link
Copy Markdown
Contributor

Description

wip

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@cataphract cataphract force-pushed the glopes/sidecar-comm branch 3 times, most recently from d9cd53f to 373c569 Compare March 24, 2026 20:29
@datadog-datadog-prod-us1
Copy link
Copy Markdown

datadog-datadog-prod-us1 bot commented Mar 24, 2026

⚠️ Tests

Fix all issues with BitsAI or with Cursor

⚠️ Warnings

🧪 15 Tests failed

helper error telemetry includes backtrace() from com.datadog.appsec.php.integration.TelemetryTests   View in Datadog   (Fix with Cursor)
java.lang.AssertionError: Expected stack_trace with Rust source references (.rs:line), got: disabled backtrace. Expression: errorLog.stack_trace.contains(.rs:)

java.lang.AssertionError: Expected stack_trace with Rust source references (.rs:line), got: disabled backtrace. Expression: errorLog.stack_trace.contains(.rs:)
	at org.codehaus.groovy.runtime.InvokerHelper.createAssertError(InvokerHelper.java:416)
	at com.datadog.appsec.php.integration.TelemetryTests.helper error telemetry includes backtrace(TelemetryTests.groovy:662)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
testSearchPhpBinaries from integration.DDTrace\Tests\Integration\PHPInstallerTest   View in Datadog   (Fix with Cursor)
DDTrace\Tests\Integration\PHPInstallerTest::testSearchPhpBinaries
Test code or tested code printed unexpected output: Searching for available php binaries, this operation might take a while.
testSimplePushAndProcess from laravel-58-test.DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest   View in Datadog   (Fix with Cursor)
DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest::testSimplePushAndProcess
Test code or tested code printed unexpected output: spanLinksTraceId: 69c3454b000000008564b11e683c26cb
tid: 69c3454b00000000
hexProcessTraceId: 8564b11e683c26cb
hexProcessSpanId: 2cef208699f39d44
processTraceId: 9612002248871388875
processSpanId: 3237842419583262020

phpvfscomposer://tests/vendor/phpunit/phpunit/phpunit:106
View all

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 59.76%
Overall Coverage: 57.81% (-2.82%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 366de49 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@pr-commenter
Copy link
Copy Markdown

pr-commenter bot commented Mar 24, 2026

Benchmarks [ tracer ]

Benchmark execution time: 2026-03-25 03:24:39

Comparing candidate commit 366de49 in PR branch glopes/sidecar-comm with baseline commit a1bb038 in branch master.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 191 metrics, 1 unstable metrics.

scenario:MessagePackSerializationBench/benchMessagePackSerialization

  • 🟥 execution_time [+10.724µs; +11.576µs] or [+10.806%; +11.665%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

  • 🟥 execution_time [+9.627µs; +11.753µs] or [+9.223%; +11.260%]

@cataphract cataphract force-pushed the glopes/sidecar-comm branch from 373c569 to 121733e Compare March 24, 2026 21:54
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 24, 2026

Codecov Report

❌ Patch coverage is 59.67213% with 492 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.84%. Comparing base (a1bb038) to head (366de49).

Files with missing lines Patch % Lines
appsec/helper-rust/src/client.rs 44.40% 144 Missing ⚠️
appsec/helper-rust/src/client/sidecar_msg.rs 81.47% 88 Missing ⚠️
appsec/helper-rust/src/server.rs 0.00% 77 Missing ⚠️
appsec/src/extension/test_mock_transport.c 58.76% 30 Missing and 10 partials ⚠️
appsec/src/extension/commands_helpers.c 66.96% 30 Missing and 7 partials ⚠️
appsec/src/extension/ddtrace.c 45.45% 30 Missing and 6 partials ⚠️
appsec/src/extension/network.c 58.82% 20 Missing and 8 partials ⚠️
appsec/helper-rust/src/lib.rs 0.00% 26 Missing ⚠️
appsec/src/extension/logging.h 0.00% 12 Missing ⚠️
appsec/src/extension/helper_process.c 66.66% 2 Missing ⚠️
... and 1 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3725      +/-   ##
==========================================
+ Coverage   68.81%   75.84%   +7.02%     
==========================================
  Files         166       66     -100     
  Lines       19030    13366    -5664     
  Branches     1797     1189     -608     
==========================================
- Hits        13095    10137    -2958     
+ Misses       5121     2662    -2459     
+ Partials      814      567     -247     
Flag Coverage Δ
helper-rust-unit 52.54% <60.16%> (+3.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
appsec/helper-rust/src/client/protocol.rs 95.07% <100.00%> (+0.01%) ⬆️
appsec/helper-rust/src/config.rs 97.77% <ø> (+0.21%) ⬆️
appsec/helper-rust/src/ffi.rs 74.48% <ø> (ø)
appsec/helper-rust/src/service/updateable_waf.rs 96.37% <100.00%> (+0.03%) ⬆️
appsec/helper-rust/src/service/waf_ruleset.rs 66.23% <ø> (ø)
appsec/helper-rust/src/telemetry.rs 74.07% <ø> (ø)
appsec/helper-rust/src/telemetry/sidecar.rs 82.60% <ø> (+3.50%) ⬆️
appsec/src/extension/commands/client_init.c 79.51% <100.00%> (+1.46%) ⬆️
appsec/src/extension/commands/request_exec.c 81.81% <100.00%> (ø)
appsec/src/extension/configuration.h 100.00% <ø> (ø)
... and 14 more

... and 34 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1bb038...366de49. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cataphract cataphract force-pushed the glopes/sidecar-comm branch 3 times, most recently from cf6dc39 to af7f0bc Compare March 25, 2026 01:51
@cataphract cataphract force-pushed the glopes/sidecar-comm branch from af7f0bc to 366de49 Compare March 25, 2026 02:04
@pr-commenter
Copy link
Copy Markdown

pr-commenter bot commented Mar 25, 2026

Benchmarks [ appsec ]

Benchmark execution time: 2026-03-25 02:42:31

Comparing candidate commit 366de49 in PR branch glopes/sidecar-comm with baseline commit a1bb038 in branch master.

Found 3 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 0 unstable metrics.

scenario:LaravelBench/benchLaravelOverhead-appsec

  • 🟩 execution_time [-1.966ms; -1.747ms] or [-13.398%; -11.911%]

scenario:SymfonyBench/benchSymfonyOverhead-appsec

  • 🟩 execution_time [-2.190ms; -2.008ms] or [-17.949%; -16.454%]

scenario:WordPressBench/benchWordPressOverhead-appsec

  • 🟩 execution_time [-7.819ms; -7.567ms] or [-17.042%; -16.492%]

@estringana estringana assigned estringana and unassigned estringana Mar 25, 2026
mlog(dd_log_debug, "Will exchange message with helper");

dd_result res = dd_conn_recv(conn, &imsg->_data, &imsg->_size);
// dd_result res = dd_conn_roundtripv(conn, iovecs, &imsg->_data,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this comment go?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants