Skip to content

ci: publish docker image for system tests#4013

Draft
MilanGarnier wants to merge 3 commits into
masterfrom
milan.garnier/publish-ci-builds
Draft

ci: publish docker image for system tests#4013
MilanGarnier wants to merge 3 commits into
masterfrom
milan.garnier/publish-ci-builds

Conversation

@MilanGarnier

@MilanGarnier MilanGarnier commented Jun 24, 2026

Copy link
Copy Markdown

Description

Adds a CI job at dd-trace-php/.gitlab/generate-package.php which pushes the build to github's container registry (similarly to what already exists for prod builds). This is necessary to enable LIBRARY_TARGET_BRANCH to work for the PHP target in utils/scripts/load-binary.sh. (mimicking what already exists for dd-trace-dotnet)

The endgoal is to have DataDog/system-tests#7209 picking up the right branch

Reviewer checklist

@MilanGarnier MilanGarnier requested a review from a team as a code owner June 24, 2026 13:15
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Jun 24, 2026

Copy link
Copy Markdown

Pipelines  Tests

Fix all issues with BitsAI

⚠️ Warnings

🚦 13 Pipeline jobs failed

DataDog/apm-reliability/dd-trace-php | PHP language tests: [8.2, amd64, zts]   View in Datadog   GitLab

DataDog/apm-reliability/dd-trace-php | test_extension_ci: [7.0]   View in Datadog   GitLab

DataDog/apm-reliability/dd-trace-php | test_extension_ci: [8.3]   View in Datadog   GitLab

View all 13 failed jobs.

1 Test performance regression detected

testUserLoginSuccessEvent from tests/Integrations/Laravel/V5_7.DDTrace\Tests\Integrations\Laravel\V5_7\AutomatedLoginEventsTest — 3.67s (+3.1s, +542%)   View in Datadog

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 54.08% (+0.00%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: eaf0612 | Docs | Datadog PR Page | Give us feedback!

@MilanGarnier MilanGarnier force-pushed the milan.garnier/publish-ci-builds branch from c7decf8 to 5894a60 Compare June 24, 2026 13:17

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c7decf82b6

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread .gitlab/generate-package.php Outdated
@MilanGarnier MilanGarnier changed the title ci: new CI job "publish docker image for system tests" ci: publish docker image for system tests Jun 24, 2026
@DataDog DataDog deleted a comment from chatgpt-codex-connector Bot Jun 24, 2026
@realFlowControl

Copy link
Copy Markdown
Member

I just recently learned that https://github.com/DataDog/public-images exists, could this do the syncing of the image for us?

@MilanGarnier

MilanGarnier commented Jun 24, 2026

Copy link
Copy Markdown
Author

@realFlowControl I didn't know publish-images either, but from what I understand, the tool seems to be centered aroung publishing releases across various sources, whereas what I want to do here is to push once a build, exclusively for system-tests to use. (but I'm really not an expert here)

@MilanGarnier MilanGarnier marked this pull request as draft June 24, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants