You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Ensure the ci-images manual job and generated image-build jobs remain runnable from development branches so image changes can be built and validated before merge.
Prevent maintainers from accidentally restricting those manual jobs with CI_COMMIT_REF_PROTECTED or CI_DEFAULT_BRANCH rules.
Clarify that these pipelines run only in the private Datadog GitLab instance and that access to manual jobs is governed by project membership and settings.
Description
Add explanatory comment to .gitlab-ci.yml above the ci-images job explaining why it must remain available on development branches and not be restricted by protected-ref rules.
Add the same guidance to the generated CI images generator .gitlab/generate-ci-images.php so generated child pipelines include the note in their header and template snippets.
Update dockerfiles/ci/README.md with an important admonition block describing that image-build jobs are intentionally available from development branches and how access is controlled.
Testing
No automated tests were run because the changes are non-functional documentation and generator comments only.
The sad reality about this PR: Codex keeps stumbling over this over and over and pings to me to fix a problem that does not exist. Hopefully, with some documentation, it stops wasting my time.
I'm slightly confused. Why would we have even get that idea of restricting jobs here? Was there some issue where that broke?
Likewise and I am not really happy with these comments as well.
Look at https://datadoghq.atlassian.net/browse/APMSP-3852
This is the second time I got pinged with a high severity issue on the same situation. I want it to stop, but apperantly Codex is not aware that our GitLab-CI jobs are not triggered by 3rd party contributors and also those jobs are manual jobs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
ci-imagesmanual job and generated image-build jobs remain runnable from development branches so image changes can be built and validated before merge.CI_COMMIT_REF_PROTECTEDorCI_DEFAULT_BRANCHrules.Description
.gitlab-ci.ymlabove theci-imagesjob explaining why it must remain available on development branches and not be restricted by protected-ref rules..gitlab/generate-ci-images.phpso generated child pipelines include the note in their header and template snippets.dockerfiles/ci/README.mdwith an important admonition block describing that image-build jobs are intentionally available from development branches and how access is controlled.Testing
Codex Task
The sad reality about this PR: Codex keeps stumbling over this over and over and pings to me to fix a problem that does not exist. Hopefully, with some documentation, it stops wasting my time.