Skip to content

Preserve ci-images manual job availability on development branches (docs and generator) - #4067

Closed
realFlowControl wants to merge 1 commit into
masterfrom
codex/review-ci-image-signing-vulnerability-severity
Closed

Preserve ci-images manual job availability on development branches (docs and generator)#4067
realFlowControl wants to merge 1 commit into
masterfrom
codex/review-ci-image-signing-vulnerability-severity

Conversation

@realFlowControl

@realFlowControl realFlowControl commented Jul 27, 2026

Copy link
Copy Markdown
Member

Motivation

  • Ensure the ci-images manual job and generated image-build jobs remain runnable from development branches so image changes can be built and validated before merge.
  • Prevent maintainers from accidentally restricting those manual jobs with CI_COMMIT_REF_PROTECTED or CI_DEFAULT_BRANCH rules.
  • Clarify that these pipelines run only in the private Datadog GitLab instance and that access to manual jobs is governed by project membership and settings.

Description

  • Add explanatory comment to .gitlab-ci.yml above the ci-images job explaining why it must remain available on development branches and not be restricted by protected-ref rules.
  • Add the same guidance to the generated CI images generator .gitlab/generate-ci-images.php so generated child pipelines include the note in their header and template snippets.
  • Update dockerfiles/ci/README.md with an important admonition block describing that image-build jobs are intentionally available from development branches and how access is controlled.

Testing

  • No automated tests were run because the changes are non-functional documentation and generator comments only.

Codex Task

The sad reality about this PR: Codex keeps stumbling over this over and over and pings to me to fix a problem that does not exist. Hopefully, with some documentation, it stops wasting my time.

@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Jul 27, 2026

Copy link
Copy Markdown

Pipelines  Tests

Unblock PR with BitsAI

⚠️ Warnings

🚦 4 Pipeline jobs failed

DataDog/apm-reliability/dd-trace-php | ASAN test_c with multiple observers: [8.5]   View in Datadog   GitLab

DataDog/apm-reliability/dd-trace-php | merge-gate   View in Datadog   GitLab

DataDog/apm-reliability/dd-trace-php | publish docker image for system tests   View in Datadog   GitLab

View all 4 failed jobs.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 60.65% (-0.02%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 9f485bc | Docs | Datadog PR Page | Give us feedback!

@bwoebi

bwoebi commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

I'm slightly confused. Why would we have even get that idea of restricting jobs here? Was there some issue where that broke?

@realFlowControl

Copy link
Copy Markdown
Member Author

I'm slightly confused. Why would we have even get that idea of restricting jobs here? Was there some issue where that broke?

Likewise and I am not really happy with these comments as well.
Look at https://datadoghq.atlassian.net/browse/APMSP-3852
This is the second time I got pinged with a high severity issue on the same situation. I want it to stop, but apperantly Codex is not aware that our GitLab-CI jobs are not triggered by 3rd party contributors and also those jobs are manual jobs.

Not 100% sure what the correct solution is.

@bwoebi

bwoebi commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

I would just discard these jira tickets. We have to accept that AI-produced output can be garbage and just ignored.

@realFlowControl
realFlowControl marked this pull request as draft July 27, 2026 17:19
@realFlowControl
realFlowControl deleted the codex/review-ci-image-signing-vulnerability-severity branch July 29, 2026 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants