fix(ci): isolate tests from egress proxy - #4078
Merged
realFlowControl merged 3 commits intoJul 30, 2026
Merged
Conversation
|
realFlowControl
changed the title
realFlowControl
marked this pull request as ready for review
July 30, 2026 09:00
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 847cfbb738
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
2 tasks
realFlowControl
changed the title
realFlowControl
force-pushed
the
florian/ciexe-714-unset-fabric-proxy-for-phpt
branch
from
July 30, 2026 10:25
914a290 to
645c602
Compare
cataphract
approved these changes
Jul 30, 2026
realFlowControl
deleted the
florian/ciexe-714-unset-fabric-proxy-for-phpt
branch
July 30, 2026 11:26
cataphract
pushed a commit
that referenced
this pull request
Aug 2, 2026
* fix(ci): isolate PHPTs from Fabric egress proxy * fix(ci): isolate integration tests from Fabric proxy * fix(appsec): unset proxy in test wrapper
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Fabric Egress Gateway now injects proxy environment variables into CI jobs and routes outbound traffic through a local
fabric-proxysidecar. This changed tests that rely on direct network failure semantics: upstream curl PHPTs received proxy response bodies instead of curl errors, curl and Guzzle integration tests reached the proxy for deliberately invalid hosts, and tracer startup diagnostics no longer reported an unreachable agent. The AppSec PHPT harness also copiedHTTP_PROXYinto$_SERVERand reported it as an incomingProxyrequest header.This unsets the HTTP, HTTPS, and fallback proxy variables immediately before PHP language, integration, web, AppSec extension, AppSec coverage, and PECL test execution. AppSec performs the cleanup in
run-tests-wrapper.sh, afterxtestdependencies have been built but before the PHPT runner starts. The proxy remains available to earlier package installation, Composer, Cargo, CMake, and service-readiness steps that may require network access, while tests run with the direct network behavior they expect.Related infrastructure rollout: CIEXE-714.
Testing
bash -n .gitlab/run_php_language_tests.sh appsec/cmake/run-tests-wrapper.shReviewer checklist