refactor(profiling): use two-time upload api in libdatadog

Author: KowalskiThomas

ddtrace/internal/datadog/profiling/dd_wrapper/src/uploader.cpp

@@ -5,8 +5,8 @@
 #include "profiler_state.hpp"
 #include "profiler_stats.hpp"
 
-#include <cerrno>   // errno
-#include <cstring>  // strerror
+#include <cerrno>  // errno
+#include <cstring> // strerror
 #include <fstream>  // ofstream
 #include <sstream>  // ostringstream
 #include <unistd.h> // getpid
@@ -122,7 +122,14 @@ Datadog::Uploader::upload_unlocked()
         .len = static_cast<uintptr_t>(to_compress_files.size()),
     };
 
-    bool ret = true;
+    // Build and send the request in one call
+    auto init_runtime_res = ddog_prof_Exporter_init_runtime(&ddog_exporter);
+    if (init_runtime_res.tag != DDOG_VOID_RESULT_OK) {
+        std::cerr << "Error initializing runtime: " << err_to_msg(&init_runtime_res.err, "Error initializing runtime")
+                  << std::endl;
+        return false;
+    }
+
     // Before starting a new upload, we need to cancel the current one (if it exists).
     // To do that, we exchange the current cancellation token with a new one (which will be used for our own upload)
     // If the current cancellation token was not null, then we use it to cancel the ongoing upload, then drop it.
@@ -138,16 +145,16 @@ Datadog::Uploader::upload_unlocked()
         ddog_CancellationToken_drop(&current_cancel);
     }
 
-    // Build and send the request in one call
-    ddog_prof_Result_HttpStatus res = ddog_prof_Exporter_send_blocking(&ddog_exporter,
-                                                                       &encoded_profile,
-                                                                       files_to_compress,
-                                                                       nullptr, // optional_additional_tags
-                                                                       optional_process_tags_ptr,
-                                                                       &internal_metadata_json_slice,
-                                                                       nullptr, // optional_info_json
-                                                                       &new_cancel_clone_for_request);
+    auto res = ddog_prof_Exporter_send_blocking(&ddog_exporter,
+                                                &encoded_profile,
+                                                files_to_compress,
+                                                nullptr, // optional_additional_tags
+                                                optional_process_tags_ptr,
+                                                &internal_metadata_json_slice,
+                                                nullptr, // optional_info_json
+                                                &new_cancel_clone_for_request);
 
+    bool ret = true;
     if (res.tag == DDOG_PROF_RESULT_HTTP_STATUS_ERR_HTTP_STATUS) { // NOLINT (cppcoreguidelines-pro-type-union-access)
         auto err = res.err;                                        // NOLINT (cppcoreguidelines-pro-type-union-access)
         errmsg = err_to_msg(&err, "Error uploading");

src/native/Cargo.toml

@@ -21,27 +21,27 @@ anyhow = { version = "1.0", optional = true }
 libc = { version = "0.2", optional = true }
 rand = "0.9"
 serde = "1.0"
-datadog-ffe = { git = "https://github.com/DataDog/libdatadog", rev = "v28.0.4", optional = true, version = "1.0.0", features = ["pyo3"] }
+datadog-ffe = { git = "https://github.com/DataDog/libdatadog", rev = "1e58e48a2bf22e472669bddb4e578e09d9c6746f", optional = true, version = "1.0.0", features = ["pyo3"] }
 serde_json = "1.0"
-datadog-remote-config = { git = "https://github.com/DataDog/libdatadog", rev = "v28.0.4" }
-datadog-tracer-flare = { git = "https://github.com/DataDog/libdatadog", rev = "v28.0.4" }
-libdd-crashtracker = { git = "https://github.com/DataDog/libdatadog", rev = "v28.0.4", optional = true }
-libdd-ddsketch = { git = "https://github.com/DataDog/libdatadog", rev = "v28.0.4", optional = true }
-libdd-library-config = { git = "https://github.com/DataDog/libdatadog", rev = "v28.0.4" }
+datadog-remote-config = { git = "https://github.com/DataDog/libdatadog", rev = "1e58e48a2bf22e472669bddb4e578e09d9c6746f" }
+datadog-tracer-flare = { git = "https://github.com/DataDog/libdatadog", rev = "1e58e48a2bf22e472669bddb4e578e09d9c6746f" }
+libdd-crashtracker = { git = "https://github.com/DataDog/libdatadog", rev = "1e58e48a2bf22e472669bddb4e578e09d9c6746f", optional = true }
+libdd-ddsketch = { git = "https://github.com/DataDog/libdatadog", rev = "1e58e48a2bf22e472669bddb4e578e09d9c6746f", optional = true }
+libdd-library-config = { git = "https://github.com/DataDog/libdatadog", rev = "1e58e48a2bf22e472669bddb4e578e09d9c6746f" }
 libdd-log = { git = "https://github.com/DataDog/libdatadog", rev = "v27.0.0" }
-libdd-data-pipeline = { git = "https://github.com/DataDog/libdatadog", rev = "v28.0.4" }
-libdd-profiling-ffi = { git = "https://github.com/DataDog/libdatadog", rev = "v28.0.4", optional = true, features = [
+libdd-data-pipeline = { git = "https://github.com/DataDog/libdatadog", rev = "1e58e48a2bf22e472669bddb4e578e09d9c6746f" }
+libdd-profiling-ffi = { git = "https://github.com/DataDog/libdatadog", rev = "1e58e48a2bf22e472669bddb4e578e09d9c6746f", optional = true, features = [
     "cbindgen",
 ] }
-libdd-common = { git = "https://github.com/DataDog/libdatadog", rev = "v28.0.4", optional = true }
-libdd-trace-utils = { git = "https://github.com/DataDog/libdatadog", rev = "v28.0.4" }
+libdd-common = { git = "https://github.com/DataDog/libdatadog", rev = "1e58e48a2bf22e472669bddb4e578e09d9c6746f", optional = true }
+libdd-trace-utils = { git = "https://github.com/DataDog/libdatadog", rev = "1e58e48a2bf22e472669bddb4e578e09d9c6746f" }
 pyo3 = { version = "0.27", features = ["extension-module", "anyhow"] }
 tracing = { version = "0.1", default-features = false }
 pyo3-ffi = { version = "0.27", optional = true }
 
 [build-dependencies]
 pyo3-build-config = "0.27"
-build_common = { git = "https://github.com/DataDog/libdatadog", rev = "v28.0.4", features = [
+build_common = { git = "https://github.com/DataDog/libdatadog", rev = "1e58e48a2bf22e472669bddb4e578e09d9c6746f", features = [
     "cbindgen",
 ] }