Commit cbe166c
authored
test(llmobs): fix unmigrated botocore test (#17874)
## Summary
- `test_llmobs_converse_guard_content_text` has been failing on `main` since #17801 merged. It was overlooked by that PR's migration: the test still uses the old `llmobs_events` fixture but never pulls in `bedrock_llmobs`, so LLMObs is never enabled and `len(llmobs_events) == 1` fails with `0 == 1`.
- Pre-#17801, `llmobs_events` transitively depended on `bedrock_llmobs` (the fixture wired LLMObs + the test span writer). The new conftest dropped that link, and every other test in `TestLLMObsBedrock` was rewritten to take `bedrock_llmobs` explicitly — except this one.
- Migrate this test to the same pattern as the three nearby `test_llmobs_converse_tool_result_*` tests: `bedrock_llmobs` + `test_spans` + `get_llmobs_input_messages(spans[0])`.
## Test plan
- [x] Ran the test locally on Python 3.10 / botocore 1.38.26 (the lowest pinned venv where `BOTO_VERSION >= (1, 34, 131)` so the `skipif` doesn't fire): passes.
- [ ] CI green on the botocore suite.
Claude session: `6d4c7e26-fb57-405b-9cd3-586ac14a911a`
Resume: `claude --resume 6d4c7e26-fb57-405b-9cd3-586ac14a911a`
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-authored-by: yun.kim <yun.kim@datadoghq.com>1 parent 27dab0c commit cbe166c
1 file changed
Lines changed: 4 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
673 | 673 | | |
674 | 674 | | |
675 | 675 | | |
676 | | - | |
| 676 | + | |
677 | 677 | | |
678 | 678 | | |
679 | 679 | | |
| |||
697 | 697 | | |
698 | 698 | | |
699 | 699 | | |
700 | | - | |
701 | | - | |
| 700 | + | |
| 701 | + | |
| 702 | + | |
702 | 703 | | |
703 | 704 | | |
704 | 705 | | |
| |||
0 commit comments