fix: avoid using svc_src: m when service is among active integration defaults#17712
fix: avoid using svc_src: m when service is among active integration defaults#17712emmettbutler wants to merge 138 commits intomainfrom
Conversation
BenchmarksBenchmark execution time: 2026-05-01 19:16:57 Comparing candidate commit 00c94e4 in PR branch Found 0 performance improvements and 3 performance regressions! Performance is the same for 584 metrics, 4 unstable metrics. scenario:iastaspects-stringio_aspect
scenario:iastaspectsospath-ospathbasename_aspect
scenario:telemetryaddmetric-1-count-metric-1-times
|
brettlangdon
left a comment
There was a problem hiding this comment.
other than the perf feedback this lgtm
I did not review all snapshots, scanning the rough shape of changes makes sense to me though why they are changing here
brettlangdon
left a comment
There was a problem hiding this comment.
question/suggestion about implementation, but otherwise lgtm
rithikanarayan
left a comment
There was a problem hiding this comment.
approved for serverless snapshots
dubloom
left a comment
There was a problem hiding this comment.
My main question is:
Why some integrations remove _dd.svc_src if service == base_service and others are setting _dd.svc_src == service.
Also why are we deleting django snapshots ?
|
@dubloom django snapshots are deleted because the tests pass without them. Presumably this is because they are associated with tests that have been deleted. The cases where svc_src == service are because of inferred base service. |
wantsui
left a comment
There was a problem hiding this comment.
LGTM! I left some small comments about some of the snapshots.
This change fixes an issue reported via Support in which
svc_srcis set tomin cases whereservicematches the_default_serviceof an active integration config. In such cases, the intended behavior is that itsvc_srcis equal toservice.The change also excludes the
svc_srctag in cases whereservice == base_service.