Skip to content

chore(profiling): typing for _asyncio.py#17716

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intomainfrom
kowalski/chore-profiling-typing-for-_asyncio-py
Apr 27, 2026
Merged

chore(profiling): typing for _asyncio.py#17716
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intomainfrom
kowalski/chore-profiling-typing-for-_asyncio-py

Conversation

@KowalskiThomas
Copy link
Copy Markdown
Contributor

@KowalskiThomas KowalskiThomas commented Apr 24, 2026

Description

Adds typing in our asyncio wrappers, as requested by @vlad-scherbich.

@cit-pr-commenter-54b7da
Copy link
Copy Markdown

Codeowners resolved as

ddtrace/profiling/_asyncio.py                                           @DataDog/profiling-python

@KowalskiThomas KowalskiThomas added changelog/no-changelog A changelog entry is not required for this PR. Profiling Continous Profling labels Apr 24, 2026
@KowalskiThomas KowalskiThomas force-pushed the kowalski/chore-profiling-typing-for-_asyncio-py branch from 3626048 to d17f5ae Compare April 24, 2026 09:45
@KowalskiThomas KowalskiThomas force-pushed the kowalski/chore-profiling-typing-for-_asyncio-py branch from d17f5ae to 573a05b Compare April 24, 2026 10:30
@KowalskiThomas KowalskiThomas changed the title chore(profiling): typing for _asyncio.py chore(profiling): typing for _asyncio.py Apr 24, 2026
@KowalskiThomas KowalskiThomas marked this pull request as ready for review April 24, 2026 12:27
@KowalskiThomas KowalskiThomas requested a review from a team as a code owner April 24, 2026 12:27
Copy link
Copy Markdown
Contributor

@vlad-scherbich vlad-scherbich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

Comment thread ddtrace/profiling/_asyncio.py
Comment thread ddtrace/profiling/_asyncio.py Outdated
Comment thread ddtrace/profiling/_asyncio.py Outdated
Copy link
Copy Markdown
Contributor

@vlad-scherbich vlad-scherbich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@datadog-prod-us1-4
Copy link
Copy Markdown
Contributor

datadog-prod-us1-4 Bot commented Apr 27, 2026

Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 6ef7644 | Docs | Datadog PR Page | Give us feedback!

@KowalskiThomas KowalskiThomas force-pushed the kowalski/chore-profiling-typing-for-_asyncio-py branch from cfbe3f0 to 6ef7644 Compare April 27, 2026 10:47
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit 4b22029 into main Apr 27, 2026
382 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot deleted the kowalski/chore-profiling-typing-for-_asyncio-py branch April 27, 2026 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog A changelog entry is not required for this PR. Profiling Continous Profling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants