Skip to content

revert(profiling): revert _DD_PROFILING_STACK_FAST_COPY default to false #17929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brettlangdon merged 2 commits into from
May 7, 2026
Merged

revert(profiling): revert _DD_PROFILING_STACK_FAST_COPY default to false #17929

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d452b6
fix(profiling): revert _DD_PROFILING_STACK_FAST_COPY default to false
taegyunkim May 6, 2026
339c95e
Merge branch 'main' into taegyunkim/prof-14568-revert-stack-fast-copy
brettlangdon May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ddtrace/internal/settings/profiling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,7 @@ class ProfilingConfigStack(DDConfig):
fast_copy = DDConfig.v(
bool,
"fast_copy",
default=True,
default=False,
help_type="Boolean",
help="Whether to use fast memory copying (safe_memcpy) instead of process_vm_readv for stack sampling.",
private=True,
Expand Down
4 changes: 0 additions & 4 deletions releasenotes/notes/profiling-phase-out-process-vm-readv-97af2e74953bb9e9.yaml
View file
Open in desktop

This file was deleted.

16 changes: 8 additions & 8 deletions riotfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3626,10 +3626,10 @@ def select_pys(min_version: str = MIN_PYTHON_VERSION, max_version: str = MAX_PYT
"protobuf": latest,
},
),
# process_vm_readv fallback (safe_memcpy is now default)
# safe_memcpy fast-copy path (process_vm_readv is the default)
Venv(
env={
"_DD_PROFILING_STACK_FAST_COPY": "0",
"_DD_PROFILING_STACK_FAST_COPY": "1",
},
pkgs={
"protobuf": latest,
Expand Down Expand Up @@ -3682,10 +3682,10 @@ def select_pys(min_version: str = MIN_PYTHON_VERSION, max_version: str = MAX_PYT
"protobuf": latest,
},
),
# process_vm_readv fallback (safe_memcpy is now default)
# safe_memcpy fast-copy path (process_vm_readv is the default)
Venv(
env={
"_DD_PROFILING_STACK_FAST_COPY": "0",
"_DD_PROFILING_STACK_FAST_COPY": "1",
},
pkgs={
"protobuf": latest,
Expand Down Expand Up @@ -3724,10 +3724,10 @@ def select_pys(min_version: str = MIN_PYTHON_VERSION, max_version: str = MAX_PYT
"protobuf": latest,
},
),
# process_vm_readv fallback (safe_memcpy is now default)
# safe_memcpy fast-copy path (process_vm_readv is the default)
Venv(
env={
"_DD_PROFILING_STACK_FAST_COPY": "0",
"_DD_PROFILING_STACK_FAST_COPY": "1",
},
pkgs={
"protobuf": latest,
Expand Down Expand Up @@ -3767,10 +3767,10 @@ def select_pys(min_version: str = MIN_PYTHON_VERSION, max_version: str = MAX_PYT
"protobuf": latest,
},
),
# process_vm_readv fallback (safe_memcpy is now default)
# safe_memcpy fast-copy path (process_vm_readv is the default)
Venv(
env={
"_DD_PROFILING_STACK_FAST_COPY": "0",
"_DD_PROFILING_STACK_FAST_COPY": "1",
},
pkgs={
"protobuf": latest,
Expand Down
Loading