Skip to content

feat(profiling): add fast-copy fallback ProfilerStats metrics [backport 4.11] (PROF-15342)#18992

Open
vlad-scherbich wants to merge 5 commits into
4.11from
backport-metrics-to-4.11
Open

feat(profiling): add fast-copy fallback ProfilerStats metrics [backport 4.11] (PROF-15342)#18992
vlad-scherbich wants to merge 5 commits into
4.11from
backport-metrics-to-4.11

Conversation

@vlad-scherbich

Copy link
Copy Markdown
Contributor

Summary

Cherry-pick of d6ee9b5 onto 4.11 (after #18972). Adds fast_copy_memory_user_disabled, fast_copy_memory_capable, and fast_copy_memory_syscall_fallback ProfilerStats metadata fields.

Test plan

  • CI green on 4.11 profiling suites
  • Cherry-pick applied; sampler.cpp conflict resolved (kept ephemeral count + new metrics)

@vlad-scherbich
vlad-scherbich requested a review from a team as a code owner July 10, 2026 21:13
@vlad-scherbich
vlad-scherbich requested a review from gyuheon0h July 10, 2026 21:13
@datadog-official

datadog-official Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Pipelines  Tests

⚠️ Warnings

🚦 10 Pipeline jobs failed

DataDog/apm-reliability/dd-trace-py | build linux serverless: [arm64, cp315-cp315, v113741357-d2b8243-manylinux2014_aarch64, 1]   View in Datadog   GitLab

DataDog/apm-reliability/dd-trace-py | build linux: [amd64, cp315-cp315, v113741491-d2b8243-musllinux_1_2_x86_64]   View in Datadog   GitLab

DataDog/apm-reliability/dd-trace-py | build linux: [arm64, cp315-cp315, v113741589-d2b8243-musllinux_1_2_aarch64]   View in Datadog   GitLab

View all 10 failed jobs.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: decac6d | Docs | Datadog PR Page | Give us feedback!

@vlad-scherbich vlad-scherbich added the Profiling Continous Profling label Jul 10, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f573264ef8

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread ddtrace/internal/datadog/profiling/stack/src/sampler.cpp Outdated
@pr-commenter

pr-commenter Bot commented Jul 10, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-07-10 21:38:09

Comparing candidate commit f573264 in PR branch backport-metrics-to-4.11 with baseline commit 0b6e17b in branch 4.11.

Found 0 performance improvements and 5 performance regressions! Performance is the same for 612 metrics, 10 unstable metrics.

scenario:iast_aspects-re_expand_aspect

  • 🟥 execution_time [+276.832µs; +315.745µs] or [+7.790%; +8.885%]

scenario:iastaspects-ljust_aspect

  • 🟥 execution_time [+87.044µs; +98.819µs] or [+14.326%; +16.265%]

scenario:iastaspectsospath-ospathbasename_aspect

  • 🟥 execution_time [+89.558µs; +98.002µs] or [+21.082%; +23.069%]

scenario:span-start

  • 🟥 execution_time [+1.359ms; +1.532ms] or [+8.693%; +9.804%]

scenario:telemetryaddmetric-1-count-metric-1-times

  • 🟥 execution_time [+196.948ns; +234.674ns] or [+9.111%; +10.857%]

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Jul 13, 2026

Copy link
Copy Markdown

Codeowners resolved as

ddtrace/appsec/_iast/_iast_request_context_base.py                      @DataDog/asm-python
ddtrace/appsec/_iast/_taint_tracking/__init__.py                        @DataDog/asm-python
ddtrace/appsec/_iast/_taint_tracking/_taint_objects.py                  @DataDog/asm-python
ddtrace/appsec/_iast/_taint_tracking/_taint_objects_base.py             @DataDog/asm-python
ddtrace/appsec/_iast/_taint_tracking/taint_tracking/taint_range.cpp     @DataDog/asm-python
ddtrace/appsec/_iast/_taint_tracking/taint_tracking/taint_range.h       @DataDog/asm-python
releasenotes/notes/fix-iast-scope-copy-ranges-to-active-slot-a1b2c3d4e5f60789.yaml  @DataDog/apm-python
releasenotes/notes/iast-fix-crash-taint-query-without-context-b3d9f1c47a2e08d6.yaml  @DataDog/apm-python
tests/appsec/iast/taint_tracking/test_context.py                        @DataDog/asm-python

@vlad-scherbich vlad-scherbich added the changelog/no-changelog A changelog entry is not required for this PR. label Jul 13, 2026
@vlad-scherbich vlad-scherbich changed the title feat(profiling): add fast-copy fallback ProfilerStats metrics [backport 4.11] feat(profiling): add fast-copy fallback ProfilerStats metrics [backport 4.11] (PROF-15342) Jul 13, 2026
@vlad-scherbich
vlad-scherbich enabled auto-merge (squash) July 14, 2026 17:07
@vlad-scherbich
vlad-scherbich disabled auto-merge July 14, 2026 17:32
@vlad-scherbich
vlad-scherbich enabled auto-merge (squash) July 18, 2026 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog A changelog entry is not required for this PR. Profiling Continous Profling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants