Skip to content

fix(native): run shutdown in thread in uwsgi#19086

Draft
VianneyRuhlmann wants to merge 2 commits into
repro/uwsgi-tokio-panicfrom
vianney/init-tokio-thread-storage-early
Draft

fix(native): run shutdown in thread in uwsgi#19086
VianneyRuhlmann wants to merge 2 commits into
repro/uwsgi-tokio-panicfrom
vianney/init-tokio-thread-storage-early

Conversation

@VianneyRuhlmann

Copy link
Copy Markdown
Contributor

Description

Testing

Risks

Additional Notes

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Jul 15, 2026

Copy link
Copy Markdown

Codeowners resolved as

releasenotes/notes/fix-uwsgi-panic-in-worker-8e0cffa85b25592b.yaml      @DataDog/apm-python

@datadog-prod-us1-6

datadog-prod-us1-6 Bot commented Jul 15, 2026

Copy link
Copy Markdown

Pipelines  Tests

Unblock PR with BitsAI

⚠️ Warnings

🚦 9 Pipeline jobs failed

DataDog/apm-reliability/dd-trace-py | build linux serverless: [arm64, cp315-cp315, v113741357-d2b8243-manylinux2014_aarch64, 1]   View in Datadog   GitLab

DataDog/apm-reliability/dd-trace-py | build linux: [amd64, cp315-cp315, v113741491-d2b8243-musllinux_1_2_x86_64]   View in Datadog   GitLab

DataDog/apm-reliability/dd-trace-py | build linux: [arm64, cp315-cp315, v113741589-d2b8243-musllinux_1_2_aarch64]   View in Datadog   GitLab

View all 9 failed jobs.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: bf6b481 | Docs | Datadog PR Page | Give us feedback!

@VianneyRuhlmann
VianneyRuhlmann changed the base branch from main to repro/uwsgi-tokio-panic July 15, 2026 18:51
@VianneyRuhlmann
VianneyRuhlmann force-pushed the vianney/init-tokio-thread-storage-early branch from 432cbd8 to da2b375 Compare July 15, 2026 19:00
@pr-commenter

pr-commenter Bot commented Jul 15, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-07-17 13:15:21

Comparing candidate commit bf6b481 in PR branch vianney/init-tokio-thread-storage-early with baseline commit 3776154 in branch repro/uwsgi-tokio-panic.

Found 1 performance improvements and 9 performance regressions! Performance is the same for 608 metrics, 10 unstable metrics.

scenario:forktime-configured

  • 🟩 execution_time [-1.937ms; -1.641ms] or [-17.066%; -14.458%]

scenario:iast_aspects-re_search_aspect

  • 🟥 execution_time [+24.022µs; +29.186µs] or [+8.396%; +10.201%]

scenario:iastaspects-add_aspect

  • 🟥 execution_time [+8.575µs; +11.560µs] or [+8.341%; +11.244%]

scenario:iastaspects-slice_aspect

  • 🟥 execution_time [+13.800µs; +16.770µs] or [+7.134%; +8.669%]

scenario:iastaspects-strip_aspect

  • 🟥 execution_time [+71.228µs; +76.295µs] or [+22.446%; +24.042%]

scenario:iastaspects-translate_aspect

  • 🟥 execution_time [+60.360µs; +69.586µs] or [+11.839%; +13.648%]

scenario:iastaspectsospath-ospathbasename_aspect

  • 🟥 execution_time [+98.069µs; +106.494µs] or [+23.257%; +25.255%]

scenario:iastaspectssplit-rsplit_aspect

  • 🟥 execution_time [+20.340µs; +26.587µs] or [+13.368%; +17.473%]

scenario:span-start

  • 🟥 execution_time [+1.560ms; +1.729ms] or [+10.132%; +11.230%]

scenario:telemetryaddmetric-1-count-metric-1-times

  • 🟥 execution_time [+213.512ns; +241.352ns] or [+10.121%; +11.441%]

@VianneyRuhlmann
VianneyRuhlmann force-pushed the vianney/init-tokio-thread-storage-early branch from 321c8c0 to f017a82 Compare July 17, 2026 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant