Skip to content

Pin apm-sdks-benchmarks to a fixed SHA for Ruby benchmarks#5974

Draft
faydef wants to merge 1 commit into
masterfrom
fayssal/fixed-ref-rb
Draft

Pin apm-sdks-benchmarks to a fixed SHA for Ruby benchmarks#5974
faydef wants to merge 1 commit into
masterfrom
fayssal/fixed-ref-rb

Conversation

@faydef

@faydef faydef commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?
Pins the apm-sdks-benchmarks GitLab include ref to a fixed SHA (52a8c07) so the Ruby benchmark infrastructure is reproducible.

Motivation:
Using ref: 'main' means any change merged to apm-sdks-benchmarks silently affects Ruby benchmark CI runs in this repo. Pinning to a SHA makes it explicit and controllable.

Change log entry
None.

Additional Notes:

⚠️ This PR must only be merged after https://github.com/DataDog/apm-sdks-benchmarks/pull/191 is merged.

Only the Ruby benchmark include is affected. No other language benchmarks reference apm-sdks-benchmarks from this repo.

How to test the change?
Trigger the Ruby benchmark pipeline and confirm it clones and checks out the pinned apm-sdks-benchmarks commit.

@dd-octo-sts dd-octo-sts Bot added the dev/ci Involves CircleCI, GitHub Actions, or GitLab label Jul 1, 2026
@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Jul 1, 2026

Copy link
Copy Markdown

Pipelines  Tests

Fix all issues with BitsAI

⚠️ Warnings

🚦 2 Pipeline jobs failed

Test macOS | Test (macos-15, 3.4)   View in Datadog   GitHub Actions

Check Pull Request CI Status | all-jobs-are-green   View in Datadog   GitHub Actions

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 90.04% (+0.00%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: fc1571f | Docs | Datadog PR Page | Give us feedback!

Points to the commit that adds APM_SDKS_BENCHMARKS_SHA support and
sets the pin, ensuring all Ruby benchmark jobs clone and checkout the
exact same commit SHA.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@faydef faydef force-pushed the fayssal/fixed-ref-rb branch from 99f3306 to fc1571f Compare July 1, 2026 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev/ci Involves CircleCI, GitHub Actions, or GitLab

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant