Skip to content

[IGNORE] Community PR 5961#5976

Draft
Strech wants to merge 4 commits into
masterfrom
community/pr-5961
Draft

[IGNORE] Community PR 5961#5976
Strech wants to merge 4 commits into
masterfrom
community/pr-5961

Conversation

@Strech

@Strech Strech commented Jul 1, 2026

Copy link
Copy Markdown
Member

⚠️ DO NOT MERGE ⚠️

dasch added 2 commits June 29, 2026 16:34
Inject and extract the DSM pathway context through the serialized job
payload so produce (enqueue) and consume (perform) checkpoints connect
across the enqueue/perform process boundary, regardless of queue adapter.
Require datadog/data_streams so the enabled? facade is defined under the
tracing-only entrypoint, avoiding a NoMethodError on every serialize.
Collapse the two single-method patches into one DataStreams module and
add a regression test for the unconfigured-DSM path.
@dd-octo-sts

dd-octo-sts Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

👋 Hey @Strech, please fill "Change log entry" section in the pull request description.

If changes need to be present in CHANGELOG.md you can state it this way

**Change log entry**

Yes. A brief summary to be placed into the CHANGELOG.md

(possible answers Yes/Yep/Yeah)

Or you can opt out like that

**Change log entry**

None.

(possible answers No/Nope/None)

Visited at: 2026-07-01 14:06:35 UTC

@dd-octo-sts dd-octo-sts Bot added integrations Involves tracing integrations tracing labels Jul 1, 2026
@dd-octo-sts

dd-octo-sts Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Typing analysis

This PR does not change typing compared to the base branch.

@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Jul 1, 2026

Copy link
Copy Markdown

Tests

Fix all issues with BitsAI

⚠️ Warnings

❄️ 4 New flaky tests detected

ActiveJob with active_job instrumentation Data Streams Monitoring when DSM is disabled does not set a consume checkpoint when deserializing from rspec   View in Datadog
super: no superclass method \`deserialize' for #<ExampleJob:0x00005641aca5a048>
Did you mean?  serialize

Failure/Error: super

NoMethodError:
  super: no superclass method \`deserialize' for #<ExampleJob:0x00005641aca5a048>
  Did you mean?  serialize
./lib/datadog/tracing/contrib/active_job/data_streams.rb:38:in \`deserialize'
./spec/datadog/tracing/contrib/rails/rails_active_job_spec.rb:265:in \`block (5 levels) in <top (required)>'
...

New test introduced in this PR is flaky.

ActiveJob with active_job instrumentation Data Streams Monitoring when DSM is enabled sets a consume checkpoint and extracts the pathway context when deserializing from rspec   View in Datadog
super: no superclass method \`deserialize' for #<ExampleJob:0x00005641ac51bf50>
Did you mean?  serialize

Failure/Error: super

NoMethodError:
  super: no superclass method \`deserialize' for #<ExampleJob:0x00005641ac51bf50>
  Did you mean?  serialize
./lib/datadog/tracing/contrib/active_job/data_streams.rb:38:in \`deserialize'
./spec/datadog/tracing/contrib/rails/rails_active_job_spec.rb:238:in \`block (5 levels) in <top (required)>'
...

New test introduced in this PR is flaky.

View in Flaky Test Management

ℹ️ Info

No other issues found (see more)

🧪 All tests passed

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 90.03% (+0.01%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 251ce66 | Docs | Datadog PR Page | Give us feedback!

@pr-commenter

pr-commenter Bot commented Jul 1, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-07-03 09:36:39

Comparing candidate commit 251ce66 in PR branch community/pr-5961 with baseline commit b85232d in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 1 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

ActiveJob 4.2 deserializes jobs via a class method, not the instance
method, so a prepended instance deserialize has no super to call and
cannot receive the queue. Gate DSM injection to ActiveJob 5.0+ and skip
the DSM specs below that version.

Replace untyped with any in the RBS and add a module self-type so steep
can resolve queue_name on the host job class.
@vpellan vpellan force-pushed the community/pr-5961 branch from 16af2bf to 251ce66 Compare July 3, 2026 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrations Involves tracing integrations tracing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants