Skip to content

docs(open_feature): address review feedback on coding guide #5989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Strech merged 7 commits into from
Jul 5, 2026
+65 −251
Merged

docs(open_feature): address review feedback on coding guide #5989

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1b629cf
docs(open_feature): trim guide, add must-follow list, Zeitwerk sectio…
TonyCTHsu Jul 3, 2026
1116d9f
Exclude symlinked CLAUDE.md from packaged gem files
TonyCTHsu Jul 3, 2026
6bbf011
Commit lib/datadog/open_feature/CLAUDE.md as an AGENTS.md import
TonyCTHsu Jul 3, 2026
77ebd91
Back the RBS and Style checklist bullets with detail sections
TonyCTHsu Jul 3, 2026
d2e11d1
Sharpen Must-follow PR bullets and require test coverage
TonyCTHsu Jul 3, 2026
b63f8b7
Add change log entry guidance to Pull requests section
TonyCTHsu Jul 3, 2026
17682d0
Merge branch 'master' into tony.hsu/open-feature-agents-guide-followup
TonyCTHsu Jul 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ This repository is the source code of a Ruby gem created by Datadog to provide D
- @lib/datadog/kit - shared product features
- @lib/datadog/data_streams - Data Streams Monitoring
- @lib/datadog/di - dynamic instrumentation (`docs/DynamicInstrumentation.md`)
- @lib/datadog/open_feature - an implementation of OpenFeature Provider https://openfeature.dev/docs/reference/sdks/server/ruby
- @lib/datadog/open_feature - an implementation of OpenFeature Provider https://openfeature.dev/docs/reference/sdks/server/ruby. See `lib/datadog/open_feature/AGENTS.md` for the coding guide for this subtree.
- @lib/datadog/opentelemetry - support OpenTelemetry API for tracing and metrics (`docs/OpenTelemetry.md`)
- @lib/datadog/profiling - profiling
- @lib/datadog/tracing - distributed tracing
Expand Down
2 changes: 1 addition & 1 deletion datadog.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ Gem::Specification.new do |spec|
.select { |fn| File.file?(fn) } # We don't want directories, only files
.reject { |fn| fn.end_with?('.so', '.bundle') } # Exclude local profiler binary artifacts
.reject { |fn| fn.end_with?('skipped_reason.txt') } # Generated by profiler; should never be distributed
.reject { |fn| File.basename(fn) == 'AGENTS.md' } # Developer tooling; not useful to gem consumers
.reject { |fn| %w[AGENTS.md CLAUDE.md].include?(File.basename(fn)) } # Developer tooling; not useful to gem consumers

spec.executables = ['ddprofrb']
spec.require_paths = ['lib']
Expand Down
Loading
Loading