Skip to content

fix(sampling): fix agent rate key name and rate limiter fractional token loss#215

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intomainfrom
ban/sampling-fix
Apr 29, 2026
Merged

fix(sampling): fix agent rate key name and rate limiter fractional token loss#215
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intomainfrom
ban/sampling-fix

Conversation

@bantonsson
Copy link
Copy Markdown
Collaborator

What does this PR do?

Fixes for issues found in this PR while moving the sampling code to libdatadog.

Motivation

Fix all the bugs

@bantonsson bantonsson requested a review from a team as a code owner April 28, 2026 09:15
@datadog-datadog-prod-us1
Copy link
Copy Markdown

datadog-datadog-prod-us1 Bot commented Apr 28, 2026

Tests

Fix all issues with BitsAI or with Cursor

⚠️ Warnings

❄️ 1 New flaky test detected

sampling::rate_limiter::tests::test_rate_limiter_accumulates_fractional_tokens from datadog-opentelemetry   View in Datadog   (Fix with Cursor)
Test has failed

ℹ️ Info

No other issues found (see more)

🧪 All tests passed

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 9f79dd6 | Docs | Datadog PR Page | Give us feedback!

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 348cc8c85b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread datadog-opentelemetry/src/sampling/rate_limiter.rs Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants