feat(baggage): fix DatadogPropagator::fields#217
Conversation
paullegranddc
left a comment
There was a problem hiding this comment.
Are you sure this is what's described in the spec?
Because from what I see, thje Keys section is under the TextMap Extract title.
The doc specific to B3 headers mentions
Fields MUST return the header names that correspond to the configured format, i.e., the headers used for the inject operation
but it seems very specific to B3 🤔
| fn fields(&self) -> opentelemetry::propagation::text_map_propagator::FieldIter<'_> { | ||
| let fields: &[String] = if self.cfg.enabled() { | ||
| &self.fields | ||
| self.inner.keys() |
There was a problem hiding this comment.
This is soo confusing... is it keys or fields? They are not always the same.
There was a problem hiding this comment.
Indeed.
I'm going to rename the keys() as fields()
There is some confusion about this:
But our |
|
@paullegranddc With regards to what fields should return, the relevant part of the generic spec is here and it says:
|
What does this PR do?
DatadogCompositePropagatorto obtain keys from injectors according to Otel spec.DatadogPropagator::fieldsproperty