Skip to content

📝 Crop API endpoint schema screenshot#37946

Merged
mauricesvay merged 2 commits into
masterfrom
msvay/crop-api-endpoint-screenshot
Jul 6, 2026
Merged

📝 Crop API endpoint schema screenshot#37946
mauricesvay merged 2 commits into
masterfrom
msvay/crop-api-endpoint-screenshot

Conversation

@mauricesvay

Copy link
Copy Markdown
Contributor

What does this PR do? What is the motivation?

Crops the screenshot added in #37785 to remove the left-hand navigation, per review feedback.

Merge instructions

Merge readiness:

  • Ready for merge

Additional notes

Removes the left-hand nav from the screenshot per review feedback on #37785.
@github-actions github-actions Bot added the Images Images are added/removed with this PR label Jul 3, 2026
@mauricesvay
mauricesvay marked this pull request as ready for review July 3, 2026 08:27
@mauricesvay
mauricesvay requested a review from a team as a code owner July 3, 2026 08:27
@mauricesvay

Copy link
Copy Markdown
Contributor Author

/review

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Automated review by Claude. AI-generated; verify before acting.

This PR only updates a binary image file (static/images/security/application_security/api/api_endpoint_definition_schema.png). No textual or code changes to review. Recommend a human reviewer verify the updated image visually reflects the schema view accurately and matches the surrounding documentation context.

Reviewed 589749adcb710e5e3bac540cfafe75183a7113beworkflow run

@estherk15 estherk15 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! A heads up, deleting the image may cause cacheing issues. Quick fix is to add the new image with a new filename without deleting the old image.

Avoids cache invalidation issues by keeping the original image
filename intact and referencing the cropped version under a new name.
@mauricesvay

Copy link
Copy Markdown
Contributor Author

Thanks for the update! A heads up, deleting the image may cause cacheing issues. Quick fix is to add the new image with a new filename without deleting the old image.

@estherk15 Thanks for the review, I've updated the screenshot path to avoid caching issues.

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Preview links (active after the build_preview check completes)

Modified Files

@mauricesvay
mauricesvay merged commit d8f34df into master Jul 6, 2026
17 checks passed
@mauricesvay
mauricesvay deleted the msvay/crop-api-endpoint-screenshot branch July 6, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Images Images are added/removed with this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants