Document agentless Feature Flags delivery for Node.js#38231
Document agentless Feature Flags delivery for Node.js#38231leoromanovsky wants to merge 10 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
|
/review |
There was a problem hiding this comment.
🤖 Automated review by Claude. AI-generated; verify before acting.
Style and consistency findings only — no blockers. New page is well-structured and adds needed content. Main issues: inconsistent capitalization of the product name Remote Configuration in several headings, capitalization of "agentless" in headings, an em-dash formatting mismatch, one ambiguous reference to a future release, and a potentially confusing "Node.js 5.116.0" (this is a dd-trace version, not a Node.js runtime version).
Reviewed 558b4e2bd7793fe98b55094028af52db9c25b5d9 — workflow run
|
/review |
There was a problem hiding this comment.
🤖 Automated review by Claude. AI-generated; verify before acting.
Content is well-structured and clearly explains the new agentless delivery mode. A few small issues: two unused reference-link definitions, one hyphenation inconsistency with feature_flags/_index.md, and a couple of clarity nits.
Reviewed b18c59f489aadfdff1a4e279836605130e5dc967 — workflow run
|
Opened DOCS-15171 to follow up with editorial review. |
aarsilv
left a comment
There was a problem hiding this comment.
Approving with some minor suggestions about changes that happened while pairing. I'll submit a commit that updates.
|
|
||
| ### Enable or disable feature flags | ||
|
|
||
| `DD_FEATURE_FLAGS_ENABLED` defaults to `true`, so new setups do not need to set it. Set it to `false` to disable the provider and both configuration delivery paths: |
There was a problem hiding this comment.
Perhaps we should highlight that disabling the provider will result in the code-provided defaults being served for all assignment requests, with a STATIC reason code.
| - With the default agentless source, CDN polling starts only when application code initializes or accesses the Datadog OpenFeature provider. | ||
| - Explicitly selecting `remote_config` starts the Agent Feature Flags subscription. It does not require application code to initialize the provider. |
| - With the default agentless source, CDN polling starts only when application code initializes or accesses the Datadog OpenFeature provider. | ||
| - Explicitly selecting `remote_config` starts the Agent Feature Flags subscription. It does not require application code to initialize the provider. | ||
|
|
||
| ### Configuration precedence |
|
|
||
| Configure the API key on the Agent, not in the application process. If Remote Configuration has been disabled on the Agent, re-enable it. See [Remote Configuration][1] for Agent setup and network requirements. | ||
|
|
||
| ### Migrate an existing Remote Configuration setup |
@aarsilv I wrote this document taking into account two commits now in review and the decisions I made with Ruben assuming they would land and are part of the specification. Please take a read of them and review whether the documentation still matches. |
Document that the SDK sends the DD-API-KEY header to custom endpoints and that HTTP is permitted only for loopback hosts, matching shipped dd-trace 5.116.0/6.5.0 behavior. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Restores content/en/feature_flags/concepts/configuration_sources.md and content/en/feature_flags/server/nodejs.md to their state before a45a054. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Motivation
The upcoming Node.js Feature Flags releases add a Datadog-managed CDN configuration source that does not require a Datadog Agent. The documentation currently presents Agent Remote Configuration as the server SDK delivery path and describes no-Agent serverless delivery as unsupported.
Customers need the new default explained before adopting the releases, including exact minimum versions and the initial limitation that no-Agent deployments do not deliver exposure or aggregate
flagevaluationevents.Related implementation: DataDog/dd-trace-js#9397
Changes
5.116.0and Node.js v66.5.0.flagevaluationevent delivery.Input needed from reviewers
*** Presenting the information in parallel with RC and the organization is the principal help needed.**