Define workflow names in validation; symmetric error shape; cover CancelledError

- Move WORKFLOW_LINUX/WORKFLOW_WINDOWS from dispatch.py to validation.py and
  have dispatch.py import them from validation. Inverts the previous arrow so
  the layer that runs first owns the constants; validation no longer pulls in
  dispatch's async/HTTP modules at import time.
- Make fetch_target's OSError handler use `if/else` for symmetry with
  verify_workflows_present_on_ref. Behavior unchanged; the two helpers now
  read identically instead of relying on `app.abort`'s `NoReturn` to keep the
  trailing abort unreachable.
- Add direct unit tests for extract_run_urls. The existing test_command tests
  only feed httpx.HTTPStatusError (an Exception), so the
  BaseException-but-not-Exception re-raise that lets CancelledError /
  KeyboardInterrupt propagate was untested in CI. New tests pin both the
  flow-control propagation contract and the both-failure message shape.

Author: AAraKKe

ddev/src/ddev/cli/release/test_agent/__init__.py

@@ -97,7 +97,7 @@ def _print_plan(
     plan on the same channel means piping the command into a file leaves stdout clean and
     keeps the whole pre-dispatch narrative coherent on stderr.
     """
-    from ddev.cli.release.test_agent.dispatch import WORKFLOW_LINUX, WORKFLOW_WINDOWS
+    from ddev.cli.release.test_agent.validation import WORKFLOW_LINUX, WORKFLOW_WINDOWS
 
     app.display_info('Dispatch plan')
     app.display_info(f'  Workflows: {WORKFLOW_LINUX}, {WORKFLOW_WINDOWS}')

ddev/src/ddev/cli/release/test_agent/dispatch.py

@@ -8,6 +8,8 @@
 import asyncio
 from typing import TYPE_CHECKING
 
+from ddev.cli.release.test_agent.validation import WORKFLOW_LINUX, WORKFLOW_WINDOWS
+
 if TYPE_CHECKING:
     from collections.abc import Sequence
 
@@ -16,9 +18,6 @@
 
     DispatchOutcome = GitHubResponse[WorkflowDispatchResult] | BaseException
 
-WORKFLOW_LINUX = 'test-agent.yml'
-WORKFLOW_WINDOWS = 'test-agent-windows.yml'
-
 # Hard-coded: the two test workflows only live on DataDog/integrations-core. Forks and other
 # integrations repos (extras, marketplace) have nothing to dispatch even if the branch/tag exists,
 # so deferring either component to repo metadata would just hide misconfiguration. If we ever

ddev/src/ddev/cli/release/test_agent/validation.py

@@ -17,14 +17,18 @@
 from dataclasses import dataclass
 from typing import TYPE_CHECKING
 
-from ddev.cli.release.test_agent.dispatch import WORKFLOW_LINUX, WORKFLOW_WINDOWS
-
 if TYPE_CHECKING:
     from ddev.cli.application import Application
 
 BRANCH_PATTERN = r'^\d+\.\d+\.x$'
 TAG_PATTERN = r'^\d+\.\d+\.\d+(-rc\.\d+)?$'
 
+# The two workflow filenames the command targets. Defined here (the layer that runs first)
+# rather than in `dispatch.py`, so the import graph flows validation -> dispatch and validation
+# does not pull in dispatch's async/HTTP machinery at module-load time.
+WORKFLOW_LINUX = 'test-agent.yml'
+WORKFLOW_WINDOWS = 'test-agent-windows.yml'
+
 WORKFLOW_FILES = [
     f'.github/workflows/{WORKFLOW_LINUX}',
     f'.github/workflows/{WORKFLOW_WINDOWS}',
@@ -116,7 +120,8 @@ def fetch_target(app: Application, target: ReleaseTarget) -> None:
         msg = str(e).lower()
         if any(fragment in msg for fragment in GIT_FETCH_MISSING_FRAGMENTS):
             app.abort(f'{kind.capitalize()} `{target.name}` not found on origin.')
-        app.abort(f'Failed to fetch {kind} `{target.name}` from origin: {e}')
+        else:
+            app.abort(f'Failed to fetch {kind} `{target.name}` from origin: {e}')
 
 
 def verify_workflows_present_on_ref(app: Application, target: ReleaseTarget) -> None:

ddev/tests/cli/release/test_agent/test_dispatch.py

@@ -0,0 +1,87 @@
+# (C) Datadog, Inc. 2026-present
+# All rights reserved
+# Licensed under a 3-clause BSD style license (see LICENSE)
+"""Direct unit tests for `dispatch.extract_run_urls`.
+
+The CLI-level tests in `test_command.py` only ever raise `httpx.HTTPStatusError` (an
+`Exception`) from the dispatch call, so they do not exercise the
+`BaseException`-but-not-`Exception` re-raise guard that lets `CancelledError` and
+`KeyboardInterrupt` propagate. These tests pin that contract on the helper directly.
+"""
+
+from __future__ import annotations
+
+import asyncio
+from typing import Any
+
+import pytest
+
+from ddev.cli.release.test_agent.dispatch import extract_run_urls
+from ddev.utils.github_async import GitHubResponse
+from ddev.utils.github_async.models import WorkflowDispatchResult
+
+
+def _ok(html_url: str) -> GitHubResponse[WorkflowDispatchResult]:
+    return GitHubResponse(
+        data=WorkflowDispatchResult(
+            workflow_run_id=1,
+            run_url=f'https://api.github.com/{html_url}',
+            html_url=html_url,
+        ),
+        headers={},
+    )
+
+
+def test_extract_run_urls_returns_both_html_urls() -> None:
+    results = [_ok('https://github.com/x/runs/1'), _ok('https://github.com/x/runs/2')]
+
+    assert extract_run_urls(results) == ('https://github.com/x/runs/1', 'https://github.com/x/runs/2')
+
+
+@pytest.mark.parametrize(
+    'flow_control_exc',
+    [
+        pytest.param(asyncio.CancelledError('user pressed ctrl-c'), id='cancelled-error'),
+        pytest.param(KeyboardInterrupt(), id='keyboard-interrupt'),
+    ],
+)
+@pytest.mark.parametrize(
+    'position',
+    [
+        pytest.param('linux', id='linux-cancelled'),
+        pytest.param('windows', id='windows-cancelled'),
+    ],
+)
+def test_extract_run_urls_reraises_flow_control_exceptions(flow_control_exc: BaseException, position: str) -> None:
+    """`CancelledError` / `KeyboardInterrupt` in either slot must propagate verbatim, not be wrapped."""
+    other = _ok('https://github.com/x/runs/sibling')
+    if position == 'linux':
+        results: list[Any] = [flow_control_exc, other]
+    else:
+        results = [other, flow_control_exc]
+
+    with pytest.raises(type(flow_control_exc)):
+        extract_run_urls(results)
+
+
+def test_extract_run_urls_wraps_regular_exception_failure_as_runtime_error() -> None:
+    """Sanity check that the `Exception` branch still produces a wrapped RuntimeError."""
+    err = RuntimeError('forbidden')
+    results = [err, _ok('https://github.com/x/runs/2')]
+
+    with pytest.raises(RuntimeError, match=r'Linux dispatch failed:.*forbidden.*runs/2'):
+        extract_run_urls(results)
+
+
+def test_extract_run_urls_both_failures_includes_both_reprs() -> None:
+    """Both-fail must surface both error reprs in the RuntimeError message (not via __notes__)."""
+    linux_err = RuntimeError('linux-side detail')
+    windows_err = RuntimeError('windows-side detail')
+
+    with pytest.raises(RuntimeError) as excinfo:
+        extract_run_urls([linux_err, windows_err])
+
+    message = str(excinfo.value)
+    assert 'Both dispatches failed' in message
+    assert 'linux-side detail' in message
+    assert 'windows-side detail' in message