Add http_status_code tag to http metrics (#23731)

* Add an http_status_code tag to metrics

* Add test to check for new status code on tags

* Removing http_status_code tag from ssl metrics

* Applying lint

* Add changelog

Author: ddog-nasirthomas

http_check/changelog.d/23731.added

@@ -0,0 +1 @@
+Add http_status_code tag to http metrics.

http_check/datadog_checks/http_check/http_check.py

@@ -183,6 +183,9 @@ def send_status_down(loginfo, down_msg):
             raise
 
         else:
+            if r is not None:
+                http_status = r.status_code
+                tags_list.append("http_status_code:{}".format(http_status))
             if use_cert_from_response:
                 peer_cert = r.raw.connection.sock.getpeercert(binary_form=True)
 

http_check/tests/test_http_integration.py

@@ -430,11 +430,16 @@ def test_data_methods(aggregator, http_check):
 
         url_tag = ['url:{}'.format(instance.get('url'))]
         instance_tag = ['instance:{}'.format(instance.get('name'))]
+        http_status_tag = ['http_status_code:{}'.format('200')]
 
         aggregator.assert_service_check(HTTPCheck.SC_STATUS, status=AgentCheck.OK, tags=url_tag + instance_tag, count=1)
-        aggregator.assert_metric('network.http.can_connect', tags=url_tag + instance_tag, value=1.0, count=1)
-        aggregator.assert_metric('network.http.cant_connect', tags=url_tag + instance_tag, value=0.0, count=1)
-        aggregator.assert_metric('network.http.response_time', tags=url_tag + instance_tag, count=1)
+        aggregator.assert_metric(
+            'network.http.can_connect', tags=url_tag + instance_tag + http_status_tag, value=1.0, count=1
+        )
+        aggregator.assert_metric(
+            'network.http.cant_connect', tags=url_tag + instance_tag + http_status_tag, value=0.0, count=1
+        )
+        aggregator.assert_metric('network.http.response_time', tags=url_tag + instance_tag + http_status_tag, count=1)
 
         # Assert coverage for this check on this instance
         aggregator.assert_all_metrics_covered()