Skip to content

[SEC-27721]: Add SIEM category to integrations#23659

Open
2uent1n wants to merge 1 commit intomasterfrom
quentin.blin/sec-27721-add-siem-category
Open

[SEC-27721]: Add SIEM category to integrations#23659
2uent1n wants to merge 1 commit intomasterfrom
quentin.blin/sec-27721-add-siem-category

Conversation

@2uent1n
Copy link
Copy Markdown
Collaborator

@2uent1n 2uent1n commented May 11, 2026

What does this PR do?

Adds Category::SIEM to existing integrations.

Motivation

See Jira ticket.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented May 11, 2026

⚠️ Recommendation: Add qa/skip-qa label

This PR does not modify any files shipped with the agent.

To help streamline the release process, please consider adding the qa/skip-qa label if these changes do not require QA testing.

@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented May 11, 2026

Validation Report

All 20 validations passed.

Show details
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and Codecov settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
dep Verify dependency pins are consistent and Agent-compatible
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
license-headers Validate Python files have proper license headers
licenses Validate third-party license attribution list
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

@2uent1n 2uent1n marked this pull request as draft May 11, 2026 09:22
@2uent1n 2uent1n marked this pull request as ready for review May 11, 2026 13:10
Copy link
Copy Markdown
Contributor

@dkirov-dd dkirov-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there might be integrations included by mistake

Comment thread apache/manifest.json
"media": [],
"classifier_tags": [
"Category::Log Collection",
"Category::SIEM",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question
Is Apache HTTP Server SIEM software?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not itself SIEM Software indeed.

We are adding this tag to all Integrations currently referenced in the Cloud SIEM Content Packs + to a small set of integrations we still don't have Content Packs for today. I used a Sheets doc shared by PM listing the "Security/SIEM" integrations.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 146716e239

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apache/manifest.json
"Supported OS::macOS",
"Category::Log Collection",
"Category::Security",
"Category::SIEM",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Add the required changelog entries

These manifest files are packaged with integrations (pyproject.toml includes /manifest.json), and the repository instructions require changelog entries for shipped Agent-file changes. This commit updates 80 shipped manifests but adds no changelog.d entries, so the SIEM category change will not be recorded in the affected integration release notes.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants