Skip to content

Bump rust version to fix failure for dependency update (cryptography)#23672

Merged
HadhemiDD merged 8 commits into
masterfrom
hs/update-rust
Jun 4, 2026
Merged

Bump rust version to fix failure for dependency update (cryptography)#23672
HadhemiDD merged 8 commits into
masterfrom
hs/update-rust

Conversation

@HadhemiDD

Copy link
Copy Markdown
Contributor

What does this PR do?

Updating the dependencies PR is failing due to old rust version, bumping the rust version for linux and windows.

Motivation

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@dd-octo-sts

dd-octo-sts Bot commented May 11, 2026

Copy link
Copy Markdown
Contributor

⚠️ Recommendation: Add qa/skip-qa label

This PR does not modify any files shipped with the agent.

To help streamline the release process, please consider adding the qa/skip-qa label if these changes do not require QA testing.


# Rust toolchain (needed for cryptography)
ENV RUST_VERSION="1.76"
ENV RUST_VERSION="1.83.0"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this have to match the rust version used in datadog-agent?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The datadog agent rust version is already at 1.91

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aiuto, as a side note, they do not need to match. These are just used because cryptography is included built by ourselves in the wheels we ship but should be disconnected from the rust version in the agent.

I would propose to hold off on this PR until we branch of for the release starting tomorrow. Unless we need any of the dependency bumps to address a CVE. I am checking that to consider whether these should be merged now or they can wait until we branch off for 7.80.

@datadog-datadog-prod-us1

This comment has been minimized.

@AAraKKe AAraKKe added the qa/skip-qa Automatically skip this PR for the next QA label May 25, 2026
@AAraKKe AAraKKe mentioned this pull request May 25, 2026
3 tasks
@dd-octo-sts

dd-octo-sts Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Validation Report

All 21 validations passed.

Show details
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and code coverage settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
dep Verify dependency pins are consistent and Agent-compatible
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
license-headers Validate Python files have proper license headers
licenses Validate third-party license attribution list
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
qa-label Validate the pull request declares whether it needs QA for the next Agent release
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

@HadhemiDD HadhemiDD enabled auto-merge June 4, 2026 09:19
@HadhemiDD HadhemiDD disabled auto-merge June 4, 2026 09:27
@HadhemiDD HadhemiDD merged commit b0b75f5 into master Jun 4, 2026
27 of 28 checks passed
@HadhemiDD HadhemiDD deleted the hs/update-rust branch June 4, 2026 09:28
@dd-octo-sts dd-octo-sts Bot added this to the 7.81.0 milestone Jun 4, 2026
@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Wheels promoted to stable storage for commit 1a9b3f9a588ef4f2f50b1b8ab1b20907f784c2d8 by @HadhemiDD.
Workflow run: https://github.com/DataDog/integrations-core/actions/runs/26947862141

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

qa/skip-qa Automatically skip this PR for the next QA team/agent-build team/agent-integrations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants