Skip to content

[DBMON-5975] Upgrade libpq to 18.3#23702

Open
eric-weaver wants to merge 14 commits into
masterfrom
eric.weaver/DBMON-5975
Open

[DBMON-5975] Upgrade libpq to 18.3#23702
eric-weaver wants to merge 14 commits into
masterfrom
eric.weaver/DBMON-5975

Conversation

@eric-weaver
Copy link
Copy Markdown
Contributor

@eric-weaver eric-weaver commented May 13, 2026

What does this PR do?

Upgrades the bundled libpq from 16.9 to 18.3 across all builder images (Linux x86_64, Linux aarch64, macOS, Windows).

On Windows, PostgreSQL 18 removed the legacy Perl MSVC build system (build.pl), so the build is migrated to Meson + Ninja. This includes:

  • Installing winflexbison (flex/bison are required build prerequisites for PostgreSQL from source)
  • Installing meson and ninja via pip
  • Replacing the build.pl/install.pl commands with meson setup + ninja + ninja install
  • Deleting the now-unused pg_config.pl override file

No integration code changes — libpq 18 is backward-compatible with all supported PostgreSQL server versions.

Motivation

We're currently behind multiple major versions that include security fixes and improvements and features

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@eric-weaver eric-weaver marked this pull request as ready for review May 18, 2026 13:04
@eric-weaver eric-weaver requested review from a team as code owners May 18, 2026 13:04
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 82582e9470

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread .builders/images/windows-x86_64/Dockerfile Outdated
@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented May 18, 2026

⚠️ Recommendation: Add qa/skip-qa label

This PR does not modify any files shipped with the agent.

To help streamline the release process, please consider adding the qa/skip-qa label if these changes do not require QA testing.

@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts Bot commented May 18, 2026

Validation Report

All 20 validations passed.

Show details
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and Codecov settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
dep Verify dependency pins are consistent and Agent-compatible
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
license-headers Validate Python files have proper license headers
licenses Validate third-party license attribution list
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants