Add OCSF DNS Activity normalization to coredns pipeline#23726
Merged
Conversation
Map CoreDNS query/response logs to OCSF DNS Activity [4003]. Adds OCSF facets, a single-class sub-pipeline (no pre-transformation), and the generated expected OCSF blocks in the test fixtures. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
jbfeldman-dd
added a commit
that referenced
this pull request
May 18, 2026
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
jbfeldman-dd
force-pushed
the
jonah.feldman/coredns-ocsf
branch
from
ce7db38 to
4757882
Compare
validate-logs flagged five OCSF facet path conflicts. Rename to the canonical form used by the existing DNS integrations and add the `type: integer` annotation expected on `ocsf.rcode_id` and `ocsf.src_endpoint.port`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
validate-logs asks for `facetType: range` on this facet path. Match the form CI's canonical-suggestion message printed for ocsf.src_endpoint.port. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
Author
|
OCSF Validations pass, except on logs that have no timestamp. 
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d7d0144feb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
cepolation-datadog
previously approved these changes
May 18, 2026
cepolation-datadog
left a comment
cepolation-datadog
left a comment
Contributor
There was a problem hiding this comment.
Doesn't make sense to have fallbacks without values imo but non-blocking so approving.
Comment on lines
+232
to
+234
| fallback: | ||
| values: {} | ||
| sources: {} |
Contributor
There was a problem hiding this comment.
Why have fallback section if empty anyways?
Comment on lines
+245
to
+247
| fallback: | ||
| values: {} | ||
| sources: {} |
Comment on lines
+295
to
+297
| fallback: | ||
| values: {} | ||
| sources: {} |
temporal-github-worker-1
Bot
dismissed
cepolation-datadog’s stale review
Review from cepolation-datadog is dismissed. Related teams and files:
- logs-integrations-reviewers
- coredns/assets/logs/coredns.yaml
Contributor
Validation ReportAll 20 validations passed. Show details
|
cepolation-datadog
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Maps CoreDNS query/response logs to OCSF DNS Activity [4003]. Adds:
OCSF sub pipeline for class DNS Activity [4003]with metadata string-builders, an arithmetic-processor that convertsduration(ns) →ocsf.response_time(ms), and aschema-processorwith category-mappers foractivity_id,connection_info.direction_id,severity_id,status_id, andrcode_id(covers all 23 OCSF rcode enum values), plus direct remappers for time, endpoint, query, and protocol fields.coredns_tests.yaml.Motivation
Bring CoreDNS into the OCSF normalization effort so Cloud SIEM detections and dashboards that key off
ocsf.*apply to CoreDNS DNS logs alongside other DNS sources (e.g., BlueCat Integrity, Cisco Umbrella DNS).Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged🤖 Generated with Claude Code