Skip to content

Add http_status_code tag to http metrics #23731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ddog-nasirthomas merged 5 commits into from
May 18, 2026
Merged

Add http_status_code tag to http metrics #23731

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2d646f5
Add an http_status_code tag to metrics
ddog-nasirthomas May 18, 2026
ab4af80
Add test to check for new status code on tags
ddog-nasirthomas May 18, 2026
ed9c871
Removing http_status_code tag from ssl metrics
ddog-nasirthomas May 18, 2026
0dd0fa3
Applying lint
ddog-nasirthomas May 18, 2026
9d76844
Add changelog
ddog-nasirthomas May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions http_check/changelog.d/23731.added
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add http_status_code tag to http metrics.
3 changes: 3 additions & 0 deletions http_check/datadog_checks/http_check/http_check.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,9 @@ def send_status_down(loginfo, down_msg):
raise

else:
if r is not None:
http_status = r.status_code
tags_list.append("http_status_code:{}".format(http_status))
if use_cert_from_response:
peer_cert = r.raw.connection.sock.getpeercert(binary_form=True)

Expand Down
11 changes: 8 additions & 3 deletions http_check/tests/test_http_integration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,11 +430,16 @@ def test_data_methods(aggregator, http_check):

url_tag = ['url:{}'.format(instance.get('url'))]
instance_tag = ['instance:{}'.format(instance.get('name'))]
http_status_tag = ['http_status_code:{}'.format('200')]

aggregator.assert_service_check(HTTPCheck.SC_STATUS, status=AgentCheck.OK, tags=url_tag + instance_tag, count=1)
aggregator.assert_metric('network.http.can_connect', tags=url_tag + instance_tag, value=1.0, count=1)
aggregator.assert_metric('network.http.cant_connect', tags=url_tag + instance_tag, value=0.0, count=1)
aggregator.assert_metric('network.http.response_time', tags=url_tag + instance_tag, count=1)
aggregator.assert_metric(
'network.http.can_connect', tags=url_tag + instance_tag + http_status_tag, value=1.0, count=1
)
aggregator.assert_metric(
'network.http.cant_connect', tags=url_tag + instance_tag + http_status_tag, value=0.0, count=1
)
aggregator.assert_metric('network.http.response_time', tags=url_tag + instance_tag + http_status_tag, count=1)

# Assert coverage for this check on this instance
aggregator.assert_all_metrics_covered()
Expand Down
Loading