[CelerData] Add slow_lock_held_time_ms and and slow_lock_wait_time_ms metrics metrics#3021
Open
jaogoy wants to merge 5 commits into
Open
[CelerData] Add slow_lock_held_time_ms and and slow_lock_wait_time_ms metrics metrics#3021jaogoy wants to merge 5 commits into
jaogoy wants to merge 5 commits into
Conversation
…rics StarRocks FE introduced two summary metrics for slow-lock observability in StarRocks/starrocks#66027 (back-ported to 4.0/3.5): - starrocks_fe_slow_lock_held_time_ms — how long locks were held when slow locks were detected (max across owners). - starrocks_fe_slow_lock_wait_time_ms — how long waiters waited before the lock was acquired. Both are emitted as Prometheus summary (quantiles 0.75/0.95/0.98/0.99/0.999 plus _sum / _count), so map them with the same three-line pattern already used by other histogram metrics in this integration. Add corresponding metadata.csv entries. Bump version to 1.3.0 and update CHANGELOG + README. Signed-off-by: Planck Li <jaogoy@gmail.com>
This comment has been minimized.
This comment has been minimized.
…rics StarRocks FE introduced two summary metrics for slow-lock observability in StarRocks/starrocks#66027 (back-ported to 4.0/3.5): - starrocks_fe_slow_lock_held_time_ms — how long locks were held when slow locks were detected (max across owners). - starrocks_fe_slow_lock_wait_time_ms — how long waiters waited before the lock was acquired. Both are emitted as Prometheus summary (quantiles 0.75/0.95/0.98/0.99/0.999 plus _sum / _count), so map them with the same three-line pattern already used by other histogram metrics in this integration. Add corresponding metadata.csv entries. Bump version to 1.3.0 and update CHANGELOG + README. Also regenerate config_models/{defaults,instance}.py via `ddev validate models celerdata -s` (ddev 16.1.1) — the generated files had drifted from their spec.yaml source since the previous sync in 1.2.0, which CI flags as out-of-sync. These changes are auto-generated and not behavioral. Signed-off-by: Planck Li <jaogoy@gmail.com>
urseberry
approved these changes
May 29, 2026
Regenerate conf.yaml.example via 'ddev validate config celerdata -s' so it matches the updated shared OpenMetrics config template. Fixes the 'validations' CI job which failed with 'conf.yaml.example is not in sync'. Signed-off-by: Planck Li <jaogoy@gmail.com>
Author
|
@urseberry Thanks for you review. |
Contributor
@jaogoy I am a technical writer and also don't know how to address that CI failure. An engineer will also review your PR, and they will advise. |
The previous floor (36.16.0) pulls ddtrace 2.10.6, whose sdist build requires pkg_resources and fails on Python 3.13 + modern setuptools, breaking the `test-minimum-base-package` CI job. Base 37.21.0 pulls ddtrace 3.12.5 which ships cp313 prebuilt wheels, so the source build step (and the pkg_resources lookup) is skipped entirely. Verified locally: `ddev test --compat celerdata` passes 2/2 in 7m02s on Python 3.13 with ddtrace 3.12.5 installed. Signed-off-by: Planck Li <jaogoy@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Celerdata/StarRocks FE introduced two summary metrics for slow-lock observability in StarRocks/starrocks#66027:
starrocks_fe_slow_lock_held_time_ms— how long locks were held when slow locks were detected (max across owners).starrocks_fe_slow_lock_wait_time_ms— how long waiters waited before the lock was acquired.Both are emitted as Prometheus summary (quantiles 0.75/0.95/0.98/0.99/0.999 plus _sum / _count), so map them with the same three-line pattern already used by other histogram metrics in this integration. Add corresponding
metadata.csventries.Motivation
It's important to monitor the lock info when the cluster is pending for a lot of loadings and queries.
Review checklist
no-changeloglabel attachedAdditional Notes
Anything else we should know when reviewing?