fix(celerdata): collect all per-db starrocks_fe_table_num series#3025
Open
jaogoy wants to merge 2 commits into
Open
fix(celerdata): collect all per-db starrocks_fe_table_num series#3025jaogoy wants to merge 2 commits into
jaogoy wants to merge 2 commits into
Conversation
## Why I'm doing this StarRocks FE exposes `starrocks_fe_table_num` interleaved with `starrocks_fe_db_size_bytes` (one pair per database) under a single `# TYPE ... gauge` line, which violates the Prometheus text exposition rule that all samples of a metric family must be contiguous. The prometheus_client streaming parser used by OpenMetrics V2 therefore splits the metric into separate families: only the first carries the `gauge` type while the rest are typed `unknown`. OpenMetricsBaseCheckV2 drops the `unknown` families via `skip_native_metric`, so only the first per-db series (db_name=information_schema) is collected and every other database silently disappears. ## What I'm doing Pin `starrocks_fe_table_num` to the `gauge` type in `METRIC_MAP`, using the same dict form already applied to `tablet_num` / `thread_pool`. An explicitly typed metric is handled by the `gauge` transformer instead of the default `native` path, which bypasses the `unknown`-type skip and lets every per-db series through. The interleaving itself is a StarRocks-side bug; pinning the type fixes it on the integration side without waiting for a StarRocks release. Fixes DataDog#2854. Signed-off-by: Planck Li <jaogoy@gmail.com>
Bump version to 1.2.2 and add the CHANGELOG entry for the table_num fix. Also regenerate conf.yaml.example and config_models via 'ddev validate ... --sync' to clear pre-existing drift from the shared OpenMetrics template, so 'ddev validate' passes. Signed-off-by: Planck Li <jaogoy@gmail.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I'm doing this
StarRocks FE exposes
starrocks_fe_table_numinterleaved withstarrocks_fe_db_size_bytes(one pair per database) under a single# TYPE ... gaugeline, which violates the Prometheus text exposition rule that all samples of a metric family must be contiguous.The
prometheus_clientstreaming parser used by OpenMetrics V2 therefore splits the metric into separate families: only the first carries thegaugetype while the rest are typedunknown.OpenMetricsBaseCheckV2drops theunknownfamilies viaskip_native_metric, so only the first per-db series (db_name=information_schema) is collected and every other database silently disappears.What I'm doing
Pin
starrocks_fe_table_numto thegaugetype inMETRIC_MAP, using the same dict form already applied totablet_num/thread_pool. An explicitly typed metric is handled by thegaugetransformer instead of the defaultnativepath, which bypasses theunknown-type skip and lets every per-db series through. The interleaving itself is a StarRocks-side bug; pinning the type fixes it on the integration side without waiting for a StarRocks release.Verified on a live Agent:
celerdata.fe.table_numnow reports all per-db series (information_schema,_statistics_,sys, plus user databases) instead of onlyinformation_schema.Fixes #2854.
Notes for reviewers
masterafterward, at which point it becomes 1.3.1. It is versioned 1.2.2 here because it currently branches offmaster(1.2.1).conf.yaml.exampleandconfig_models/are regenerated viaddev validate ... --syncto clear pre-existing drift from the shared OpenMetrics config template (not specific to this change).