Pre-sort map keys inside list items in _tests.yaml fixtures#3027
Conversation
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
devflow unqueued this merge request: It did not become mergeable within the expected time |
Review from thibaultkrebs is dismissed. Related teams and files:
- logs-integrations-reviewers
- contrast_security_adr/assets/logs/contrast-security-adr_tests.yaml
- doppler/assets/logs/doppler_tests.yaml
- f5-distributed-cloud/assets/logs/f5-distributed-cloud-services_tests.yaml
- jamf_protect/assets/logs/jamfprotect_tests.yaml
- lacework/assets/logs/lacework_tests.yaml
- loadrunner_professional/assets/logs/loadrunner_professional_tests.yaml
- vercel/assets/logs/vercel_tests.yaml
What does this PR do?
Pre-sort map keys inside list-item maps in
_tests.yamlpipeline test fixtures, to avoid a spurious diff when the upstream change lands.MapHelper.deepSortcurrently sorts map keys recursively at all depths but stops when it encounters a list — maps nested inside list items are left unsorted. A pending change (logs-backend#138681) extendsdeepSortto also recurse into lists, so maps inside list items will have their keys sorted the next time fixtures are regenerated.This PR proactively applies that same ordering so the regeneration produces no diff.