Skip to content

Commit ff8f273

Browse files
committed
Add back cases to test float32 values
These cases were not covered since Sketch only supports integers.
1 parent ba956d6 commit ff8f273

1 file changed

Lines changed: 69 additions & 13 deletions

File tree

dogstatsd-http-core/src/test/java/com/datadoghq/dogstatsd/http/serializer/PayloadBuilderTest.java

Lines changed: 69 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,8 @@ public void handle(byte[] p) {
5555
.close();
5656

5757
b.rate("lm").setInterval(10).addPoint(100, 3.14).close();
58+
b.rate("no").addPoint(100, 1).addPoint(110, 1.5).close();
59+
b.rate("pq").addPoint(100, 1L << 25).addPoint(110, 1.5).close();
5860

5961
b.close();
6062

@@ -66,11 +68,11 @@ public void handle(byte[] p) {
6668
new int[] {
6769
// MetricData
6870
(3 << 3) | 2,
69-
167,
71+
220,
7072
1,
7173
// dictNameStr
7274
(1 << 3) | 2,
73-
17,
75+
23,
7476
3,
7577
97,
7678
98,
@@ -88,6 +90,12 @@ public void handle(byte[] p) {
8890
2,
8991
108,
9092
109, // lm
93+
2,
94+
110,
95+
111, // no
96+
2,
97+
112,
98+
113, // pq
9199
// dictTagsStr
92100
(2 << 3) | 2,
93101
12,
@@ -141,57 +149,73 @@ public void handle(byte[] p) {
141149
0,
142150
// types
143151
(10 << 3) | 2,
144-
4,
152+
6,
145153
0x11,
146154
0x03,
147155
0x14,
148156
0x32,
157+
0x22,
158+
0x32,
149159
// names
150160
(11 << 3) | 2,
151-
4,
161+
6,
162+
2,
163+
2,
152164
2,
153165
2,
154166
2,
155167
2,
156168
// tags
157169
(12 << 3) | 2,
158-
4,
170+
6,
159171
2,
160172
1,
161173
4,
162174
3,
175+
0,
176+
0,
163177
// resources
164178
(13 << 3) | 2,
165-
4,
179+
6,
166180
2,
167181
1,
168182
0,
169183
0,
184+
0,
185+
0,
170186
// intervals
171187
(14 << 3) | 2,
172-
4,
188+
6,
173189
0,
174190
0,
175191
0,
176192
10,
193+
0,
194+
0,
177195
// numPoints
178196
(15 << 3) | 2,
179-
4,
197+
6,
180198
2,
181199
1,
182200
2,
183201
1,
202+
2,
203+
2,
184204
// timestamps
185205
(16 << 3) | 2,
186206
1,
187-
7,
207+
11,
188208
200,
189209
1,
190210
20,
191211
19,
192212
0,
193213
20,
194214
19,
215+
0,
216+
20,
217+
19,
218+
20,
195219
// valsSint64
196220
(17 << 3) | 2,
197221
1,
@@ -206,10 +230,22 @@ public void handle(byte[] p) {
206230
4,
207231
6,
208232
10,
209-
// valsFloat64, list(pack('<d', 3.14))
210-
(19 << 3) | 2,
233+
// valsFloat32, list(pack('<ff', 1, 1.5))
234+
(18 << 3) | 2,
211235
1,
212236
8,
237+
0,
238+
0,
239+
128,
240+
63,
241+
0,
242+
0,
243+
192,
244+
63,
245+
// valsFloat64, list(pack('<ddd', 3.14, 1<<25, 1.5))
246+
(19 << 3) | 2,
247+
1,
248+
24,
213249
31,
214250
133,
215251
235,
@@ -218,6 +254,22 @@ public void handle(byte[] p) {
218254
30,
219255
9,
220256
64,
257+
0,
258+
0,
259+
0,
260+
0,
261+
0,
262+
0,
263+
128,
264+
65,
265+
0,
266+
0,
267+
0,
268+
0,
269+
0,
270+
0,
271+
248,
272+
63,
221273
// sketchNumBins
222274
(20 << 3) | 2,
223275
1,
@@ -245,19 +297,23 @@ public void handle(byte[] p) {
245297
// sourceTypeName
246298
(23 << 3) | 2,
247299
1,
248-
4,
300+
6,
301+
0,
302+
0,
249303
0,
250304
0,
251305
0,
252306
0,
253307
// origins
254308
(24 << 3) | 2,
255309
1,
256-
4,
310+
6,
257311
2,
258312
0,
259313
0,
260314
0,
315+
0,
316+
0,
261317
});
262318
}
263319

0 commit comments

Comments
 (0)