jbachorik's comment

zhengyu123 · zhengyu123 · commit 0b128b57ec17 · 2025-06-16T10:32:37.000-04:00
diff --git a/ddprof-lib/src/main/cpp/threadFilter.cpp b/ddprof-lib/src/main/cpp/threadFilter.cpp
@@ -86,6 +86,7 @@ void ThreadFilter::clear() {
   _size = 0;
 }
 
+// The mapping has to be reversible: f(f(x)) == x
 int ThreadFilter::mapThreadId(int thread_id) {
   // We want to map the thread_id inside the same bitmap
   static_assert(BITMAP_SIZE >= (u16)0xffff, "Potential verflow");

Original file line number	Diff line number	Diff line change
`@@ -86,6 +86,7 @@ void ThreadFilter::clear() {`
`86`	`86`	`_size = 0;`
`87`	`87`	`}`
`88`	`88`
	`89`	`+// The mapping has to be reversible: f(f(x)) == x`
`89`	`90`	`int ThreadFilter::mapThreadId(int thread_id) {`
`90`	`91`	`// We want to map the thread_id inside the same bitmap`
`91`	`92`	`static_assert(BITMAP_SIZE >= (u16)0xffff, "Potential verflow");`