Skip to content

Commit 1d054cc

Browse files
committed
Drop stale J9 MALLOC_CHECK_ skip (PROF-15360 fixed as PROF-15364)
The skip's only justification was PROF-15360, closed as invalid in favor of PROF-15364 (isRawPointer() false-positive, fixed by this PR). No separate J9 heap-corruption issue is on record, so J9 now gets the same MALLOC_CHECK_/MALLOC_PERTURB_ coverage as glibc/HotSpot.
1 parent b71ca62 commit 1d054cc

1 file changed

Lines changed: 3 additions & 6 deletions

File tree

build-logic/conventions/src/main/kotlin/com/datadoghq/profiler/ProfilerTestPlugin.kt

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -208,14 +208,11 @@ class ProfilerTestPlugin : Plugin<Project> {
208208
// Turn silent glibc heap corruption (e.g. a use-after-free write into a
209209
// freed chunk) into an immediate, attributable SIGABRT instead of a crash
210210
// much later in an unrelated allocation. Only meaningful against glibc's
211-
// own malloc: skip on musl (no MALLOC_CHECK_ support), skip whenever a
212-
// sanitizer/allocator already replaces malloc via LD_PRELOAD, and skip on
213-
// J9 (its own allocator usage trips a pre-existing, unrelated heap
214-
// corruption that needs separate investigation — see PROF-15360).
211+
// own malloc: skip on musl (no MALLOC_CHECK_ support), and skip whenever a
212+
// sanitizer/allocator already replaces malloc via LD_PRELOAD.
215213
if (PlatformUtils.currentPlatform == Platform.LINUX &&
216214
!PlatformUtils.isMusl() &&
217-
!testEnv.containsKey("LD_PRELOAD") &&
218-
!PlatformUtils.isTestJvmJ9()
215+
!testEnv.containsKey("LD_PRELOAD")
219216
) {
220217
put("MALLOC_CHECK_", "3")
221218
put("MALLOC_PERTURB_", (1..255).random().toString())

0 commit comments

Comments
 (0)