Skip to content

Commit 47b8b58

Browse files
committed
fix(profiler): guard line-number-table Deallocate against nullptr, assert on dealloc failure
1 parent f4ee43a commit 47b8b58

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

ddprof-lib/src/main/cpp/flightRecorder.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -411,9 +411,9 @@ void Lookup::fillJavaMethodInfo(MethodInfo *mi, jmethodID method,
411411
line_number_table = nullptr;
412412
Counters::increment(LINE_NUMBER_TABLE_UNREADABLE);
413413
}
414-
jvmtiError dealloc_err = jvmti->Deallocate((unsigned char *)line_number_table);
415-
if (dealloc_err != JVMTI_ERROR_NONE) {
416-
TEST_LOG("Unexpected error while deallocating linenumber table: %d", dealloc_err);
414+
if (line_number_table != nullptr) {
415+
jvmtiError dealloc_err = jvmti->Deallocate((unsigned char *)line_number_table);
416+
assert(dealloc_err == JVMTI_ERROR_NONE && "Unexpected error while deallocating linenumber table");
417417
}
418418
if (owned_table != nullptr) {
419419
mi->_line_number_table = std::make_shared<SharedLineNumberTable>(

0 commit comments

Comments
 (0)