Added assertion for potential mapped thread id overflow

zhengyu.gu · zhengyu.gu · commit bb2a1168e887 · 2025-06-11T10:57:03.000-04:00
diff --git a/ddprof-lib/src/main/cpp/threadFilter.cpp b/ddprof-lib/src/main/cpp/threadFilter.cpp
@@ -86,6 +86,8 @@ void ThreadFilter::clear() {
 }
 
 int ThreadFilter::mapThreadId(int thread_id) {
+  // We want to map the thread_id inside the same bitmap
+  static_assert(BITMAP_SIZE >= (u16)0xffff, "Potential verflow");
   u16 lower16 = (u16)(thread_id & 0xffff);
   lower16 = ((lower16 & 0x00ff) << 8) | ((lower16 & 0xff00) >> 8);
   int tid = (thread_id & ~0xffff) | lower16;

Original file line number	Diff line number	Diff line change
`@@ -86,6 +86,8 @@ void ThreadFilter::clear() {`
`86`	`86`	`}`
`87`	`87`
`88`	`88`	`int ThreadFilter::mapThreadId(int thread_id) {`
	`89`	`+ // We want to map the thread_id inside the same bitmap`
	`90`	`+ static_assert(BITMAP_SIZE >= (u16)0xffff, "Potential verflow");`
`89`	`91`	`u16 lower16 = (u16)(thread_id & 0xffff);`
`90`	`92`	`lower16 = ((lower16 & 0x00ff) << 8) \| ((lower16 & 0xff00) >> 8);`
`91`	`93`	`int tid = (thread_id & ~0xffff) \| lower16;`