Skip to content

Commit f2592a8

Browse files
jbachorikclaude
andcommitted
Fix WallClockASGCT::timerLoop skipping every other thread
Remove the spurious extra ThreadList::next() call in the no-filter fallback branch of collectThreads. The loop already reads one tid per iteration via the hasNext()/next() pattern; the trailing next() advanced the cursor a second time, so tids was populated with only the 1st, 3rd, 5th, ... entries. Impact: when threadFilter->enabled() is false, wallclock ticks sampled only half of eligible threads. The context-filtered path is unaffected. JIRA: PROF-14332 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 9858fc3 commit f2592a8

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

ddprof-lib/src/main/cpp/wallClock.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,6 @@ void WallClockASGCT::timerLoop() {
170170
if (tid != OS::threadId()) {
171171
tids.push_back(tid);
172172
}
173-
tid = thread_list->next();
174173
}
175174
delete thread_list;
176175
}

0 commit comments

Comments
 (0)