Skip to content

Commit 08f85eb

Browse files
authored
chore(crashtracking): default errors intake crash report upload to be on (#1902)
# What does this PR do? Errors intake is GAed. We should default to sending reports to the new intake. # Motivation What inspired you to submit this pull request? # Additional Notes Anything else we should know when reviewing? # How to test the change? Describe here in detail how the change can be validated.
1 parent c03245d commit 08f85eb

1 file changed

Lines changed: 6 additions & 15 deletions

File tree

libdd-crashtracker/src/crash_info/errors_intake.rs

Lines changed: 6 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ impl ErrorsIntakeSettings {
111111
errors_intake_dd_url: parse_env::str_not_empty(Self::DD_ERRORS_INTAKE_DD_URL),
112112
shared_lib_debug: parse_env::bool(Self::_DD_SHARED_LIB_DEBUG).unwrap_or(false),
113113
errors_intake_enabled: parse_env::bool(Self::DD_CRASHTRACKING_ERRORS_INTAKE_ENABLED)
114-
.unwrap_or(false),
114+
.unwrap_or(true),
115115

116116
agent_uds_socket_found: (|| {
117117
#[cfg(unix)]
@@ -883,31 +883,22 @@ mod tests {
883883
}
884884

885885
#[test]
886-
fn test_errors_intake_enabled_flag() {
886+
fn test_errors_intake_disabled_flag() {
887887
let _lock = ENV_TEST_LOCK.lock().unwrap_or_else(|e| e.into_inner());
888888

889-
// Test default behavior (should be enabled)
890889
clear_errors_intake_env();
891-
let cfg = ErrorsIntakeConfig::from_env();
892-
assert!(!cfg.is_errors_intake_enabled());
893890

894-
// Test explicitly enabled
895-
std::env::set_var("DD_CRASHTRACKING_ERRORS_INTAKE_ENABLED", "true");
891+
// Default behavior is enabled
896892
let cfg = ErrorsIntakeConfig::from_env();
897893
assert!(cfg.is_errors_intake_enabled());
898894

899-
// Test explicitly disabled
900-
std::env::set_var("DD_CRASHTRACKING_ERRORS_INTAKE_ENABLED", "false");
901-
let cfg = ErrorsIntakeConfig::from_env();
902-
assert!(!cfg.is_errors_intake_enabled());
903-
904895
// Test with uploader
905896
let uploader = ErrorsIntakeUploader::new(&None).unwrap();
906-
assert!(!uploader.is_enabled());
897+
assert!(uploader.is_enabled());
907898

908-
std::env::set_var("DD_CRASHTRACKING_ERRORS_INTAKE_ENABLED", "true");
899+
std::env::set_var("DD_CRASHTRACKING_ERRORS_INTAKE_ENABLED", "false");
909900
let uploader = ErrorsIntakeUploader::new(&None).unwrap();
910-
assert!(uploader.is_enabled());
901+
assert!(!uploader.is_enabled());
911902
}
912903

913904
#[test]

0 commit comments

Comments
 (0)